Use info logic/#82 #105

seonghunYang · 2024-05-16T05:31:13Z

📌 작업 내용

구현 내용 및 작업 했던 내역

로그아웃, 회원탈퇴 로직 구현
모바일 버전 side-navigation 컴포넌트 구현
user-info-navigation 컴포넌트를 반응형으로 변경
사용자 상태(비회원, 성적표 미입력 등)에 따른 뷰 분기 처리 구현
일부 컴포넌트를 적절한 계층에 배치하도록 리팩터링

🤔 고민 했던 부분

의도했는지는 모르겠지만, RSC를 사용하면 버튼 하나도 컴포넌트로 추상화하여 선언형으로 만들게 되는 부분이 있습니다. 다 좋은데, 컴포넌트의 네이밍이 걱정스럽습니다. 컴포넌트 네이밍에서 의도가 잘 드러나지 않는 부분을 발견하면 알려주세요.
기존 뷰에서 페이지 수준으로 navigation과 side-nav의 계층을 변경했습니다. 이는 navigation에 사용자 관련 로직을 포함하는 컴포넌트를 참조해야 하기 때문입니다.

🔊 도움이 필요한 부분

사이드 네비게이션에 표시되는 사용자 정보가 성적표 미입력 상태일 때 적절한 문구가 필요합니다. 어떤 문구가 좋을까요?

…database

…ete functionality

….mock.ts

…MyPage

github-actions · 2024-05-16T05:33:26Z

🚀storybook: https://65ccb85d5afe55a024495bc0-jzhyixuopo.chromatic.com/

github-actions · 2024-05-16T05:38:27Z

🚀storybook: https://65ccb85d5afe55a024495bc0-ejtpvwmcee.chromatic.com/

github-actions · 2024-05-16T05:38:38Z

🚀storybook: https://65ccb85d5afe55a024495bc0-xzjyxjlzuq.chromatic.com/

…MyPage

… responsive design

… for responsive design

…nal functionality

…uthorized errors

… components to match new folder structure

github-actions · 2024-05-16T07:49:10Z

🚀storybook: https://65ccb85d5afe55a024495bc0-bmuandtcrv.chromatic.com/

github-actions · 2024-05-16T07:49:14Z

🚀storybook: https://65ccb85d5afe55a024495bc0-ybavzszzgj.chromatic.com/

yougyung · 2024-05-16T12:09:48Z

컴포넌트 네이밍에서 의도가 잘 드러나지 않는 부분을 발견하면 알려주세요.

의도가 모호하다고 느껴진 부분은 따로 없었던 것 같아요. 수고하셨습니다 !

사이드 네비게이션에 표시되는 사용자 정보가 성적표 미입력 상태일 때 적절한 문구가 필요합니다. 어떤 문구가 좋을까요?

  name: '소중한 GUEST' 
  major: '성적표를 입력하고, 졸업 여부를 확인하세요',

  name:  '명지인'
  major: '성적표를 입력하고, 졸업 여부를 확인하세요',

yougyung · 2024-05-16T12:15:37Z

app/(sub-page)/components/side-navigation-bar.tsx

+      <SheetTrigger className="h-6">
+        <HamburgerMenuIcon className="w-6 h-6 text-white" />;
+      </SheetTrigger>
+      <SheetContent className="z-3">


tailwind config파일을 보면 z-index에 대한 재정의를 확인할 수 있습니다. 해당 style속성으로 교체가 필요할 것 같아요.

z-3이 해당 재정의를 반영한 것 아닌가요? 더 설명해주시겠어요?

tailwind.config.ts에서 아래 재정의를 확인할 수 있습니다

zIndex: { 1: '100', // upper layout, navigation bar, main page content 2: '200', // upper content , main page graduation cap 3: '300', // upper all },

음, 뭔가 착오가 있는 것 같네요. tailwind.config.ts에서 말씀하신 것 처럼 z-index를 재정의하면, 'zIndex-1', 'zIndex-2'로 사용하는것이 아니라, 'z-1', 'z-2’로 사용했을 때 동작합니다. 재정의하지 않았을 때는 'z-10', 'z-20'이고요. 서비스에서 'zIndex-1'을 사용하셨다면, 아마 동작하지 않았을 것입니다. 확인 부탁드립니다.

확인해봤는데 지금까지 잘못적용되고 있었네요 감사합니다 ! z-index관련 수정은 일괄적으로 제가 진행할게요.

app/(sub-page)/components/side-navigation-bar.tsx

gahyuun

고생하셨습니다 컴포넌트 네이밍에서 모호하다고 느껴진 부분은 딱히 없었던 것 같아요
성적표 미입력 문구는 언니 의견이 적절해보이네요!

app/ui/view/molecule/sheet/sheet.tsx

app/(sub-page)/components/navigation-bar.tsx

app/(sub-page)/my/page.tsx

app/ui/user/user-info-navigator/user-delete-modal.tsx

app/ui/user/user-info-navigator/sign-in-link-button.tsx

Co-authored-by: yougyung <youkyeongs@naver.com>

seonghunYang · 2024-05-20T06:36:00Z

컴포넌트 네이밍에서 의도가 잘 드러나지 않는 부분을 발견하면 알려주세요.

의도가 모호하다고 느껴진 부분은 따로 없었던 것 같아요. 수고하셨습니다 !

사이드 네비게이션에 표시되는 사용자 정보가 성적표 미입력 상태일 때 적절한 문구가 필요합니다. 어떤 문구가 좋을까요?
  name: '소중한 GUEST' 
  major: '성적표를 입력하고, 졸업 여부를 확인하세요',
  name:  '명지인'
  major: '성적표를 입력하고, 졸업 여부를 확인하세요',

0405b87

…ad of type for props

… update sheet.tsx component styles

Co-authored-by: 박가현 <81469686+gahyuun@users.noreply.github.com>

…and add handleSideNavOpen function

github-actions · 2024-05-20T07:19:33Z

🚀storybook: https://65ccb85d5afe55a024495bc0-kejentvhdx.chromatic.com/

…k from specific paths

github-actions · 2024-05-20T08:20:39Z

🚀storybook: https://65ccb85d5afe55a024495bc0-whyblxsojl.chromatic.com/

github-actions · 2024-05-20T08:21:42Z

🚀storybook: https://65ccb85d5afe55a024495bc0-mdwybddnew.chromatic.com/

seonghunYang added 15 commits April 25, 2024 11:29

[web] feat: Update middleware.ts to improve guest path handling

0f60da0

feat: Add signOut function and redirect to sign-in page

ae40793

feat: Add SignOutButton component to UserInfoNavigator

944399f

feat: Add USER_DEELETE dialog key

4e06500

feat: Add UserDeleteButton component to UserInfoNavigator

f6a2f42

feat: Add UserDeleteModal component

1ccb7b3

feat: Add FloatingComponentContainer to MyPage

5863c3b

feat: Add user delete dialog and handle toggle

f125a64

refactor: Refactor user-handler.mock.ts to add devModeAuthGuard function

804fa95

feat: Add unit tests for UserInfoNavigator component and update mock …

d4e50cc

…database

feat: Update UserDeleteModal component to improve UI and add user del…

eca405f

…ete functionality

feat: add UserDeleteRequestBody interface

8bbc2f5

feat: Add deleteUser function to mockDatabase and update user-handler…

259ed10

….mock.ts

feat: add deleteUser function and update UserDeleteModal component

364e312

chore: merge commit

c2488a7

seonghunYang requested review from yougyung and gahyuun as code owners May 16, 2024 05:31

seonghunYang closed this May 16, 2024

remove: Remove FloatingComponentContainer and add UserDeleteModal to …

773c350

…MyPage

seonghunYang added 2 commits May 16, 2024 05:33

fix: Fix typo in dialog key for user delete functionality

c3bc438

fix: Fix middleware.ts to use consistent variable naming conventions

b6c6ae6

seonghunYang reopened this May 16, 2024

seonghunYang closed this May 16, 2024

seonghunYang added 4 commits May 16, 2024 05:43

remove: Remove FloatingComponentContainer and add UserDeleteModal to …

336fd90

…MyPage

feat: Update NavigationBar component to include HamburgerMenuIcon for…

15493c5

… responsive design

refactor: Update NavigationBar component to include SideNavigationBar…

740215f

… for responsive design

feat: Update SideNavigationBar component to include Sheet for additio…

3ae0765

…nal functionality

seonghunYang added 3 commits May 16, 2024 07:31

refactor: Refactor user.query.ts and user.validation.ts to handle una…

630192c

…uthorized errors

refactor: Refactor file paths for NavigationBar and SideNavigationBar…

778c16f

… components to match new folder structure

refactor: Refactor SignButtonGroup component to conditionally

2626f5e

seonghunYang reopened this May 16, 2024

yougyung reviewed May 16, 2024

View reviewed changes

app/(sub-page)/components/side-navigation-bar.tsx Outdated Show resolved Hide resolved

yougyung previously approved these changes May 16, 2024

View reviewed changes

app/(sub-page)/components/side-navigation-bar.tsx Outdated Show resolved Hide resolved

gahyuun reviewed May 16, 2024

View reviewed changes

seonghunYang dismissed yougyung’s stale review via cde228b May 20, 2024 06:26

seonghunYang and others added 2 commits May 20, 2024 15:26

Update app/(sub-page)/components/side-navigation-bar.tsx

cde228b

Co-authored-by: yougyung <youkyeongs@naver.com>

refactor: Update user-info-navigator.tsx and sheet.tsx components

0405b87

seonghunYang and others added 6 commits May 20, 2024 06:44

refactor: Refactor SideNavigationBar component to use interface inste…

3b0a865

…ad of type for props

refactor: Refactor Sheet component styles in sheet.tsx

1d6d7b8

refactor: Refactor navigation-bar.tsx and my/page.tsx components, and…

15d27d7

… update sheet.tsx component styles

Update app/ui/user/user-info-navigator/user-delete-modal.tsx

2dea51a

Co-authored-by: 박가현 <81469686+gahyuun@users.noreply.github.com>

refactor: Refactor SideNavigationBar component to use useDialog hook …

2f32ce3

…and add handleSideNavOpen function

Merge branch 'main' into use-info-logic/#82

78edbd4

seonghunYang added 2 commits May 20, 2024 08:15

refactor: Refactor SignButtonGroup component to import Button and Lin…

e6a148c

…k from specific paths

refactor: Refactor SignButtonGroup component to import Button and Lin…

d161298

…k from specific paths

gahyuun approved these changes May 20, 2024

View reviewed changes

yougyung approved these changes May 21, 2024

View reviewed changes

seonghunYang merged commit ec223db into main May 21, 2024
3 checks passed

seonghunYang deleted the use-info-logic/#82 branch May 21, 2024 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use info logic/#82 #105

Use info logic/#82 #105

seonghunYang commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

yougyung commented May 16, 2024 •

edited

Loading

yougyung May 16, 2024

seonghunYang May 20, 2024

yougyung May 20, 2024

seonghunYang May 21, 2024

yougyung May 21, 2024 •

edited

Loading

gahyuun left a comment

seonghunYang commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 20, 2024

Use info logic/#82 #105

Use info logic/#82 #105

Conversation

seonghunYang commented May 16, 2024 • edited Loading

📌 작업 내용

🤔 고민 했던 부분

🔊 도움이 필요한 부분

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

yougyung commented May 16, 2024 • edited Loading

yougyung May 16, 2024

Choose a reason for hiding this comment

seonghunYang May 20, 2024

Choose a reason for hiding this comment

yougyung May 20, 2024

Choose a reason for hiding this comment

seonghunYang May 21, 2024

Choose a reason for hiding this comment

yougyung May 21, 2024 • edited Loading

Choose a reason for hiding this comment

gahyuun left a comment

Choose a reason for hiding this comment

seonghunYang commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 20, 2024

seonghunYang commented May 16, 2024 •

edited

Loading

yougyung commented May 16, 2024 •

edited

Loading

yougyung May 21, 2024 •

edited

Loading