Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: response code 설정 #152

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: response code 설정 #152

merged 2 commits into from
Oct 18, 2024

Conversation

gahyuun
Copy link
Member

@gahyuun gahyuun commented Oct 11, 2024

📌 작업 내용

구현 내용 및 작업 했던 내역

  • 에러 코드 노션을 기반으로 Response code 상수 구현했습니다
  • 회의때 구현하면서 채워나가는 걸로 정했어서,, 템플릿 정도만 만들었습니다.!

@gahyuun gahyuun self-assigned this Oct 11, 2024
Copy link

yougyung
yougyung previously approved these changes Oct 11, 2024
@@ -0,0 +1,26 @@
export const RESPONSE_CODE = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 코드라는 특징이 드러나는 변수명으로 변경되면 더 좋을 것 같아요!

Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 수고하셨습니다
  • 저도 RESPONSE_CODE 보다 에러 코드라는 의미가 들어간 네이밍이 더 적절할 것 같습니다!

@gahyuun
Copy link
Member Author

gahyuun commented Oct 12, 2024

@seonghunYang @yougyung 의견 감사합니다 수정했습니다~!

Copy link

@yougyung
Copy link
Member

수고 많으셨어요 !

@gahyuun gahyuun merged commit 475558c into main Oct 18, 2024
2 of 3 checks passed
@gahyuun gahyuun deleted the feat/response-code branch October 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants