Skip to content

Commit

Permalink
[chore][GraphQL] Clean-up unused commands (#18287)
Browse files Browse the repository at this point in the history
## Description

Remove commands to generate examples, markdown and schema from the main
binary as we do not use them:

- Instead of generating examples, we have hand-crafted examples in our
docs. Removing this code also removes a test that forces regeneration of
a markdown file from these docs (which we also were not using).
- We also never used the output from the `generate-schema` sub-command,
because the schema was always available as a file, or via introspection
commands from the running service.
- Logic for gathering examples to test has been moved into the test
file, to avoid including test-only code in the main library.

## Test plan

CI

## Description 

Describe the changes or additions included in this PR.

## Test plan 

How did you test the new or updated feature?

## Stack

- #17543
- #17692 
- #17693 
- #17696 
- #17697 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [x] GraphQL: The GraphQL binary no longer supports generating
examples, or exporting its own schema as these commands have been unused
for some time.
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
amnn committed Aug 19, 2024
1 parent b400418 commit a5eabbb
Show file tree
Hide file tree
Showing 9 changed files with 134 additions and 2,089 deletions.
7 changes: 0 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@ jsonrpsee = { git = "https://github.com/wlmyng/jsonrpsee.git", rev = "b1b3007847
json_to_table = { git = "https://github.com/zhiburt/tabled/", rev = "e449317a1c02eb6b29e409ad6617e5d9eb7b3bd4" }
leb128 = "0.2.5"
lru = "0.10"
markdown-gen = "1.2.1"
match_opt = "0.1.2"
miette = { version = "7", features = ["fancy"] }
mime = "0.3"
Expand Down
1 change: 0 additions & 1 deletion crates/sui-graphql-rpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ lru.workspace = true
move-binary-format.workspace = true
move-disassembler.workspace = true
move-ir-types.workspace = true
markdown-gen.workspace = true
mysten-metrics.workspace = true
mysten-network.workspace = true
move-core-types.workspace = true
Expand Down
Loading

0 comments on commit a5eabbb

Please sign in to comment.