Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[consensus_adapter] consensus_adapter_tests is orphaned #4983

Closed
huitseeker opened this issue Oct 4, 2022 · 0 comments · Fixed by #5810
Closed

[consensus_adapter] consensus_adapter_tests is orphaned #4983

huitseeker opened this issue Oct 4, 2022 · 0 comments · Fixed by #5810
Assignees
@asonnino

Comments

@huitseeker
Copy link
Contributor

#1449 introduced file crates/sui-core/src/unit_tests/consensus_adapter_tests.rs.
#1467 removed the reference to this file (merged as ddbfffa ) in crates/sui-core/src/consensus_adapter.rs but did not remove the test file.

The file is still present today: https://github.com/MystenLabs/sui/blob/957d718579cd9eeb280fd1461347d4ea7e680023/crates/sui-core/src/unit_tests/consensus_adapter_tests.rs

Either the test file should be removed, or the tests should be included in compilation (and fixed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asonnino asonnino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): Remove unused test file huitseeker/sui
2 participants
@huitseeker @asonnino