[CLI] fix command default value problem #17993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… command package name parameter
… command package name parameter
… command package name parameter
…set the default value of `--test-multisig` to `false`, because it cannot be set to `false` in the command line. So current the generated zkLogin addresses will always be multisig address, and it is not possible to be single-sig address anymore
…set the default value of `--test-multisig` to `false`, because it cannot be set to `false` in the command line. So current the generated zkLogin addresses will always be multisig address, and it is not possible to be single-sig address anymore. The `--fixed` parameter also has the same problem.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@howtosui is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
joyqvq
approved these changes
May 30, 2024
|
@howtosui can you update the release notes as well with a descriptive message of the fix? |
@stefan-mysten I have already updated the release notes, please take a look, thanks! |
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
## Description [CLI] fix `sui keytool zk-login-sign-and-execute-tx` command, should set the default value of `--test-multisig` to `false`, because it cannot be set to `false` in the command line. So current the generated zkLogin addresses will always be multisig address, and it is not possible to be single-sig address anymore. The `--fixed` parameter also has the same problem. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: `sui keytool zk-login-sign-and-execute-tx`: set the default value for `--test-multisig` and `--fixed` flags to `false`, because it cannot be set to false in the command line. - [ ] Rust SDK: --------- Co-authored-by: bityoume <bityoume@qq.com> Co-authored-by: Ashok Menon <amenon94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[CLI] fix
sui keytool zk-login-sign-and-execute-txcommand, should set the default value of--test-multisigtofalse, because it cannot be set tofalsein the command line. So current the generated zkLogin addresses will always be multisig address, and it is not possible to be single-sig address anymore.The
--fixedparameter also has the same problem.Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui keytool zk-login-sign-and-execute-txdefault value for--test-multisigand--fixedflags tofalse, because it's not possible to set them to false using the command line.