Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKG - Switch to V1 #18233

Merged
merged 19 commits into from
Jun 19, 2024
Merged

DKG - Switch to V1 #18233

merged 19 commits into from
Jun 19, 2024

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Jun 13, 2024

Description

Refactor the DKG to allow protocol upgrades of the cryptographic protocol, and migrate to V1 (controlled by a protocol config parameter).

Test plan

Existing tests and the "Continuous" GH workflow.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@benr-ml benr-ml requested a review from akichidis as a code owner June 13, 2024 09:55
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:28am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:28am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:28am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:28am

@benr-ml benr-ml requested a review from mystenmark as a code owner June 13, 2024 12:05
@benr-ml benr-ml marked this pull request as draft June 13, 2024 16:03
@benr-ml benr-ml marked this pull request as ready for review June 16, 2024 12:01
@benr-ml benr-ml requested a review from aschran June 16, 2024 12:01
@@ -501,12 +505,20 @@ pub struct AuthorityEpochTables {

/// Records messages processed from other nodes. Updated when receiving a new dkg::Message
/// via consensus.
pub(crate) dkg_processed_messages: DBMap<PartyId, dkg::ProcessedMessage<PkG, EncG>>,
pub(crate) dkg_processed_messages_v2: DBMap<PartyId, VersionedProcessedMessage>,
#[deprecated]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd not mark these as deprecated until we actually remove the code that uses the old tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather be explicit about it, they should not be used for new code

Copy link
Contributor

@aschran aschran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the updates, just have a few final nits and clicking approve so you can merge after that

crates/sui-core/src/epoch/randomness.rs Outdated Show resolved Hide resolved
@benr-ml benr-ml merged commit bbfaafc into main Jun 19, 2024
47 checks passed
@benr-ml benr-ml deleted the ben/dkg_v1 branch June 19, 2024 11:54
tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Jul 29, 2024
## Description 

Refactor the DKG to allow protocol upgrades of the cryptographic
protocol, and migrate to V1 (controlled by a protocol config parameter).

## Test plan 

Existing tests and the "Continuous" GH workflow.
 
---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [x] Protocol: 
- [x] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants