Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Remove TransactionBlockFilter.recvAddress and AddressTransactionBlockRelation.RECV #19805

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

amnn
Copy link
Member

@amnn amnn commented Oct 10, 2024

Description

These fields were flagged for deprecation in 1.34 and have been replaced in 1.35 by

  • TransactionBlockFilter.affectedAddress and
  • AddressTransactionBlockRelation.AFFECTED

Which offer a similar (but not exactly the same) semantics, but without confusion around the sender address which was often also an implicit recipient of a transaction.

Test plan

sui$ cargo nextest run -p sui-graphql-rpc
sui$ cargo nextest run -p sui-graphql-rpc --features staging
sui$ cargo nextest run -p sui-graphql-e2e-tests

Stack


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL: TransactionBlockFilter.recvAddress and AddressTransactionBlockRelation.RECV have been replace by TransactionBlockFilter.affectedAddress and AddressTransactionBlockRelation.AFFECTED which offer similar semantics, but without confusion around the sender address which was also often (but not always) an implicit recipient. Now we don't distinguish between senders and recipients -- we only have senders and "affected" addresses which were touched by the transaction in some way.
  • CLI:
  • Rust SDK:
  • REST API:

@amnn amnn requested review from lxfind, bmwill and gegaowp October 10, 2024 20:41
@amnn amnn self-assigned this Oct 10, 2024
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 10:48pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 10:48pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 10:48pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 10:48pm

Base automatically changed from amnn/gql-rm-sign-addr to main October 11, 2024 22:08
amnn added 3 commits October 11, 2024 23:45
…tionBlockRelation.RECV

## Description

These fields were flagged for deprecation in 1.34 and have been replaced in 1.35 by

- `TransactionBlockFilter.affectedAddress` and
- `AddressTransactionBlockRelation.AFFECTED`

Which offer a similar (but not exactly the same) semantics, but without
confusion around the sender address which was often also an implicit
recipient of a transaction.

## Test plan

```
sui$ cargo nextest run -p sui-graphql-rpc
sui$ cargo nextest run -p sui-graphql-rpc --features staging
sui$ cargo nextest run -p sui-graphql-e2e-tests
```
@amnn amnn force-pushed the amnn/gql-rm-rev-addr branch from ad8a1cb to abed6e8 Compare October 11, 2024 22:46
@amnn amnn merged commit 2cddd9d into main Oct 11, 2024
50 checks passed
@amnn amnn deleted the amnn/gql-rm-rev-addr branch October 11, 2024 23:58
amnn added a commit that referenced this pull request Oct 14, 2024
## Description

All references to these fields have been removed from readers, so we can
stop keeping it up-to-date. Once this change lands, we can also clean
these tables from the schema.

## Test plan

```
sui$ cargo nextest run -p sui-indexer
```

## Stack

- #19708 
- #19802 
- #19803 
- #19804 
- #19805 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [x] Indexer: Indexer no longer fills the `tx_sender` and
`tx_recipient` tables.
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants