-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add move 2024 Conventions as comments to the new package example #20344
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Thank you for your PR @yanganto! It is a fresh and interesting improvement, but I'm afraid filling every new project wit coding conventions may come out as noisy, and instead I suggest changing it to a single line with a link to coding conventions. Let me know if you're comfortable doing that, or we can pick it up some other time. |
For developer experience, they just want to deliver a product with high quality, and do not want anyone to say their code is bad after product shipped. Previous commit is exactly a new developer will want in my imagine. For me, I will not insist on this PR or anything. My current topic is to bring the best practice to developer/new comer, I just try to make this smooth an easier. If there is no real best practice at this moment, it is still fine for me. |
Description
Add Conventions as comments to a new package whensui move new
sui move new
Test plan
Release notes
sui move new