-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update object version assignment tables to include object start version in the key #20527
Open
aschran
wants to merge
12
commits into
main
Choose a base branch
from
aschran/cov2-core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in the key In preparation for `ConsensusV2` objects: Adds new versions of `assigned_shared_object_versions` and `next_shared_object_versions` tables that include the object's consensus start version in the key. Updates all existing users to expect the new variant and maps existing versions onto the new variant.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 5, 2024 22:16 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 5, 2024 22:36 — with
GitHub Actions
Inactive
mystenmark
reviewed
Dec 13, 2024
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 16, 2024 20:26 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 16, 2024 20:47 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 16, 2024 21:42 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 18, 2024 17:27 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 19, 2024 18:45 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 19, 2024 18:45 — with
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 21, 2024 00:13 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for
ConsensusV2
objects:Adds new versions of
assigned_shared_object_versions
andnext_shared_object_versions
tables that include the object's consensus start version in the key.Updates all existing users to expect the new variant and maps existing versions onto the new variant.
Test plan
Updated unit tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.