[Consensus] introduce consensus only simtests #20683
Open
+531
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ip allocation issues. Create example simtest.
…. Extract the authority building method and reuse across containers.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
akichidis
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mwtian
reviewed
Dec 19, 2024
| sui-macros.workspace = true | ||
| sui-protocol-config.workspace = true | ||
| sui-simulator.workspace = true |
There was a problem hiding this comment.
This should be in [target.'cfg(msim)'.dependencies], and potentially other additional dependencies.
There was a problem hiding this comment.
Or maybe it is better to have a consensus-simulator crate?
| @@ -0,0 +1,11 @@ | |||
| // Copyright (c) Mysten Labs, Inc. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pub mod node; | |||
| }; | ||
|
|
||
| #[derive(Clone)] | ||
| #[allow(unused)] |
| use std::sync::Arc; | ||
| use tracing::info; | ||
|
|
||
| pub(crate) struct AuthorityNodeContainer { |
There was a problem hiding this comment.
Why is it necessary to create this struct when not using simtest target?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR is introducing the framework to enable us run Consensus-only simtests. Looking on the existing sui-swarm it would be a bit challenging to reuse as APIs are different and especially when we need to access consensus specific components.
The PR is using similar patterns that have been used in sui-swarm but I am expecting to refine this as we go. This might be a good start for now. A simple simtest method has been added for the time being
test_committee_start_simple. Eventually we want to replace the tests onauthority_nodeand add a few more cases. Motivation to do this has been the Garbage Collection work when investigating some edge cases where reproducibility was important to confirm the issues.Example to run this simtest with additional logging, a high regional variance in latency, and outputting the result in
output.txtTest plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.