-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gql] Increase EPOCH_DURATION_MS to reduce tests interacting with reconfiguration #20692
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
…sactions to timeout? noticed that fund_address_and_return_gas was frequently timing out, but this is a test function that is used rather frequently elsewhere.
…to advance epoch as needed
72916c0
to
e9baae9
Compare
Thanks @wlmyng. No expert here, but I was wondering if it wouldn't make sense to have a higher epoch duration to around 60s, instead of requiring to force_reconfiguration. Also, there might have been a reason as to why the duration was set to 10s. Do you happen to know why? |
I've actually bumped the epoch duration to 300s, but otherwise some indefinitely long amount of time would work I think the original idea was that we'd keep EPOCH_DURATION_MS short for testing. But what ends up happening is that transactions end up waiting for reconfiguration, which may even happen back to back, causing transactions to time out. What we should do instead is basically set epoch duration to some indefinitely long amount, and users of Note that this only affects the And I think it was set to 10s basically since its conception. Think the last relevant change was from 14 months ago, from me (ignoring Brandon's pg refactor) |
Description
When we submit a transaction to the test cluster while the nodes are reconfiguring for the new epoch, they will likely time out, causing several tests to frequently flake out.
Test plan
Flakey tests pass without multiple retries
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.