Upgrade errors for additive and deponly policies #20695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
4f6d491 to
137b942
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 22, 2024
| 4 │ module upgrades::upgrades { | ||
| │ ^^^^^^^^ New unexpected struct 'NewStruct'. | ||
| │ | ||
| = Structs are part of a module's public interface and cannot be changed during an upgrade. |
There was a problem hiding this comment.
Should this be "removed or changed" to line up with the new wording you're using elsewhere?
| @@ -90,7 +90,7 @@ error[Compatibility E01005]: type parameter mismatch | |||
| 46 │ public fun add_type_param<T, U>(a: T): T { return a } | |||
| │ ^^^^^^^^^^^^^^ Expected 1 type parameter, found 2 | |||
| │ | |||
| = Functions are part of a module's public interface and cannot be changed during an upgrade. | |||
| = Functions are part of a module's public interface and cannot be removed or changed during an 'compatible' upgrade. | |||
There was a problem hiding this comment.
Just noticed this here (there may be other places).
Suggested change
| = Functions are part of a module's public interface and cannot be removed or changed during an 'compatible' upgrade. | |
| = Functions are part of a module's public interface and cannot be removed or changed during a 'compatible' upgrade. |
| errors: Vec<UpgradeCompatibilityModeError>, | ||
| } | ||
|
|
||
| impl Default for CliInclusionCheckMode { |
There was a problem hiding this comment.
You can derive this Default (clippy may even complain to you to do that).
| impl InclusionCheckMode for CliInclusionCheckMode { | ||
| type Error = Vec<UpgradeCompatibilityModeError>; | ||
|
|
||
| fn module_name_mismatch(&mut self, _old_address: &Identifier, _new_address: &Identifier) {} |
There was a problem hiding this comment.
Is a module name mismatch even possible? I thought we performed this check by first lining up modules by their name. Should this case be removed from the interface?
| diags.extend(module_diags); | ||
| } | ||
| None => { | ||
| // TODO USE |
| @@ -920,6 +1224,14 @@ fn function_signature_mismatch_diag( | |||
|
|
|||
| let def_loc = func_sourcemap.definition_location; | |||
|
|
|||
| let reason = if public_visibility_related_error { | |||
| "Functions are part of a module's public interface \ | |||
| and cannot be removed or changed during an 'compatible' upgrade." | |||
There was a problem hiding this comment.
Ah, here it is.
Suggested change
| and cannot be removed or changed during an 'compatible' upgrade." | |
| and cannot be removed or changed during a 'compatible' upgrade." |
Comment on lines
+1794
to
+1795
| and cannot be changed during a 'compatible' upgrade." | ||
| .to_string() |
There was a problem hiding this comment.
nit: strange indentation/line-breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support additive and deponly policies for upgrade errors
Test plan
snapshot testing
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.