Fix a bug on bytes_to_address() conversion
#625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-koshy
approved these changes
Mar 2, 2022
mwtian
added a commit
that referenced
this pull request
Sep 12, 2022
…ncy (#625) * SocketAddr -> Multiaddr * fixup! SocketAddr -> Multiaddr * fixup! fixup! SocketAddr -> Multiaddr * fixup! fixup! fixup! SocketAddr -> Multiaddr * add comment * fixup! add comment
mwtian
added a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
…ncy (MystenLabs#625) * SocketAddr -> Multiaddr * fixup! SocketAddr -> Multiaddr * fixup! fixup! SocketAddr -> Multiaddr * fixup! fixup! fixup! SocketAddr -> Multiaddr * add comment * fixup! add comment
This was referenced Nov 10, 2022
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have unified the size of the two different addresses. A direct conversion will be just fine now.
Also filed #624 to add tests on native functions.