Merge libmythfreesurround into libmyth/audio #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulmus-scott
force-pushed
the
freesurround
branch
from
b16ae16
to
588a94b
Compare
QString is only for the logging, which is the only use of other MythTV code.
which was its only user. If it didn't use mythlogging.h, and thus QString, it would be entirely standard C++, not depending on Qt or any of our libraries, only depending on FFmpeg.
freesurround_decoder.cpp: This was identical to a code block before the if. freesurround.cpp: The fsurround_params constructor is never called explicitly, so just set the default values in the struct definition. Those values are immediately overwritten in the FreeSurround constructor anyways. In FreeSurround::putFrames(), copy the shadowed variables into the places they are used.
ulmus-scott
force-pushed
the
freesurround
branch
from
588a94b
to
1bf48b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libmythfreesurround was only used once in libmyth/audio, so move it there.
Checklist