This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix output, fix previous ignored clippy warnings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* as of the error reworking commit, tasks sometimes didn't erase
lines when it should have. most specifically at the beginning
of tasks being executed, and all tasks completing. this is now
fixed, as the task_inidcator ignores logs that happened before
it started, and properly counts how many lines it added, that it
needs to erase.
* we've reworked all of the codebase, so almost all clippy warnings
that were previously ignored, are no longer ignored, and code
has been rewritten so the lint step passes.
* There are some "clippy::too_many_arguments" being ignored,
I intend to fix these, but these require more of a deft hand,
and so I don't want to rush it. reworking may also not be needed
once I try it. (This is currently the most ignored clippy warning
according too: rust-lang/rust-clippy#5418)
and reasoning I agree with is there.
* There is one: `#[allow(unused)]` for pipeline descriptions. This
is true, it is unused right now, but I want to keep it in the
schema because I do want to render the pipeline in list one day.
I just haven't found quite a way to do it yet, but i added it in
because I know I want to do it (and I don't want to remove it).
* this has also resulted in a giant split up of docker executor,
so it is no longer all in one gigantic file. This really _really_
needed to be done, so I'm glad I finally did it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of the error reworking commit, tasks sometimes didn't erase
lines when it should have. most specifically at the beginning
of tasks being executed, and all tasks completing. this is now
fixed, as the task_inidcator ignores logs that happened before
it started, and properly counts how many lines it added, that it
needs to erase.
we've reworked all of the codebase, so almost all clippy warnings
that were previously ignored, are no longer ignored, and code
has been rewritten so the lint step passes.
I intend to fix these, but these require more of a deft hand,
and so I don't want to rush it. reworking may also not be needed
once I try it. (This is currently the most ignored clippy warning
according too: Most commonly ignored lints rust-lang/rust-clippy#5418)
and reasoning I agree with is there.
#[allow(unused)]for pipeline descriptions. Thisis true, it is unused right now, but I want to keep it in the
schema because I do want to render the pipeline in list one day.
I just haven't found quite a way to do it yet, but i added it in
because I know I want to do it (and I don't want to remove it).
this has also resulted in a giant split up of docker executor,
so it is no longer all in one gigantic file. This really really
needed to be done, so I'm glad I finally did it.