Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: add dict postprocessing in sync comparison #613

Closed
wants to merge 2 commits into from
Closed

feat: add dict postprocessing in sync comparison #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cb271d
feat: add dict postprocessing in sync comparison
LordOfPolls Aug 22, 2022
2afe3e3
docs: correct typing
LordOfPolls Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion naff/models/naff/application_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,9 @@ def _compare_options(local_opt_list: dict, remote_opt_list: dict) -> bool:
"max_value": ("max_value", None),
"min_value": ("min_value", None),
}
post_process: Dict[str, Callable] = {
"choices": lambda l: [d | {"name_localizations": {}} if len(d) == 2 else d for d in l],
}

if local_opt_list != remote_opt_list:
if len(local_opt_list) != len(remote_opt_list):
Expand All @@ -1091,7 +1094,9 @@ def _compare_options(local_opt_list: dict, remote_opt_list: dict) -> bool:
else:
for local_name, comparison_data in options_lookup.items():
remote_name, default_value = comparison_data
if local_option.get(local_name, default_value) != remote_option.get(remote_name, default_value):
if local_option.get(local_name, default_value) != post_process.get(remote_name, lambda l: l)(
remote_option.get(remote_name, default_value)
):
return False

else:
Expand Down