Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: Correctly reschedule tasks when they return a new trigger #642

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

silasary
Copy link
Collaborator

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

When I originally implemented the return trigger functionality, I missed that there was a .reschedule() method. I also missed that without using it, passing DateTriggers wouldn't work, as the task would have already stopped itself.

Changes

  • Changed Task.__call__ to use the helper method, rather than assigning self.trigger directly.

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls merged commit b30a494 into dev Sep 14, 2022
@LordOfPolls LordOfPolls deleted the task-reschedule branch September 14, 2022 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants