This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: Correctly reschedule tasks when they return a new trigger #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
When I originally implemented the return trigger functionality, I missed that there was a .reschedule() method. I also missed that without using it, passing DateTriggers wouldn't work, as the task would have already stopped itself.
Changes
Task.__call__
to use the helper method, rather than assigningself.trigger
directly.Checklist
Python 3.10.x