Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

refactor: help with attrs typing of app cmds #701

Merged
merged 1 commit into from
Oct 31, 2022
Merged

refactor: help with attrs typing of app cmds #701

merged 1 commit into from
Oct 31, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This pr helps with IDE type recognition for application command-related classes.

Changes

  • Localised fields now declare str type

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Oct 28, 2022
@LordOfPolls LordOfPolls merged commit e05b6cc into 2.x Oct 31, 2022
@LordOfPolls LordOfPolls deleted the app_cmd_typing branch October 31, 2022 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlbertUnruh AlbertUnruh AlbertUnruh approved these changes

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordOfPolls @silasary @AlbertUnruh