Simplify pagination using Enumerator::Lazy #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanthropus
force-pushed
the
simplify-pagination
branch
from
cbe51fa
to
59bf7eb
Compare
|
The remaining Rubocop failure is not in any code that I modified. |
|
Great! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves compatibility with the existing pagination methods while leveraging a lazy enumerator to simplify the implementation. The other advantage is that using the new
lazy_paginatemethod directly allows users to take advantage of all the additional methods available to lazy enumerators, such astakeorfirst, without needing to code those methods into this library.