Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 support #615

Merged
merged 10 commits into from
May 17, 2021
Merged

Ruby 3 support #615

merged 10 commits into from
May 17, 2021

Conversation

atog
Copy link
Contributor

@atog atog commented May 7, 2021

I ran into a problem (wrong number of arguments) passing optional params to the variables endpoint using Ruby 3.

The problem related to this change: Keyword arguments are separated from other arguments (https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/).

Copy link
Owner

@NARKOZ NARKOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I'll merge it after the comments get addressed.

lib/gitlab.rb Show resolved Hide resolved
lib/gitlab.rb Show resolved Hide resolved
lib/gitlab.rb Outdated Show resolved Hide resolved
@NARKOZ NARKOZ merged commit 6fc4203 into NARKOZ:master May 17, 2021
@NARKOZ
Copy link
Owner

NARKOZ commented May 17, 2021

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants