Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add get changelog data endpoint #645

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Conversation

andrcuns
Copy link
Contributor

Copy link
Owner

@NARKOZ NARKOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've left comments.

lib/gitlab/client/repositories.rb Outdated Show resolved Hide resolved
@@ -132,7 +132,7 @@

describe '.generate_changelog' do
before do
stub_post('/projects/3/repository/changelog', 'changelog')
stub_post('/projects/3/repository/changelog', 'generate_changelog')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stub response filenames to better correspond to method names in which test they are used.

BTW, I was the one who also added original generate_changelog method.

Co-authored-by: Nihad Abbasov <nihad@42na.in>
@NARKOZ NARKOZ merged commit e6764c5 into NARKOZ:master Jun 26, 2022
@NARKOZ
Copy link
Owner

NARKOZ commented Jun 26, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants