Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.3dev add cmake system redo #8

Open
wants to merge 2,033 commits into
base: master
Choose a base branch
from
Open

V1.3dev add cmake system redo #8

wants to merge 2,033 commits into from

Conversation

tcumby
Copy link

@tcumby tcumby commented May 7, 2023

Hi Ryan,

This is the basic CMake build system with scikit-builld used to build the package (utilizing the CMake build system). The Github CI is able to build on macOS (13), Ubuntu 20.04 and Windows (2022 Server). Right now I have a build failure with WIndows & Python 3.7 in the CI, but all other permutations of macOS 13 / Ubuntu 20.04 and Python 3.6 - 3.10 are building. We should also look at the flake8 linter failures on the various python samples.

Currently it is pulling libtmpl from my fork and the add-cmake-build-system-redo branch.

Best regards,
Ty

@ryanmaguire
Updates to ModelFromGEO.
e8a94c5
@ryanmaguire
Adding test data for CompareTAU and CRing Ripples.
4dd31b2
@ryanmaguire
Updated figures for ModelFromGEO.
f7165e1
@ryanmaguire
Added Perturbed Newton method, and new tests.
b0bd2b0
@ryanmaguire
Some small fixes.
998b493
@ryanmaguire
Fixed the plot appearance.
38c8305
@ryanmaguire
Updates to the polynomial calculations.
6f3ec5a
@ryanmaguire
Stuff for MTR Fig 4.
fd99c95
@ryanmaguire
Added MTR polynomials.
a932a8a
@ryanmaguire
Moved various error checks to the C level.
b1d4b89
@ryanmaguire
MTR polynomials in C.
09303d0
@ryanmaguire
Updated some of the mathematical functions.
fd2ac01
@ryanmaguire
Updating header files.
c3be57f
@ryanmaguire
Adding MTR polynomials.
00578dd
@ryanmaguire
Added MTR Fig 4 and 5.
c5a7d7b
@ryanmaguire
Some more updates.
24d9eb1
@ryanmaguire
General updates and organization changes.
c2efada
@ryanmaguire
Updated MTR figures.
3b734c9
@ryanmaguire
Rearranging some files.
df8837a
@ryanmaguire
Cleanup and Uranus data.
c478747
@ryanmaguire
Some more cleanup.
768d91e
@ryanmaguire
Added/updated error check for data range.
3bc033c
@ryanmaguire
Updated Legendre function to include error checks.
a62d263
@ryanmaguire
Added error checks to perturbed Newton and Ellipse.
d5687ea
@ryanmaguire
Small fix to include statements.
ab72f9c
@ryanmaguire
Added FFT Functionality (still testing)
1f08182
@ryanmaguire
Updated API. Stiil need to update linking later.
1fbf854
@ryanmaguire
Reorganizing and cleaning. Still needs some fixing.
748089e
@ryanmaguire
Fixed incorrect data type declarations.
4f3de35
@ryanmaguire
Moved string parsing to special_functions.c.
37ae12c
tcumby added 20 commits April 30, 2023 10:34
@tcumby
Re-formatting
9b05f20
@tcumby
Add a Github CI config
1b45b46
@tcumby
Don't install libtmpl's headers
870410a
@tcumby
Add v1.3dev-add-cmake-system-redo to list of branches to spawn the CI
9142a95
@tcumby
Apparently we need to fully specify python versions?
d4cb922
@tcumby
Correct the files specification for the 'pretty-format-yaml` pre-co…
908acbb 
…mmit hook
@tcumby
Preserver qutoes for the 'pretty-format-yaml` pre-commit hook
7bb2b73
@tcumby
Reformatting
e633726
@tcumby
Fix the python versions to lower point-point releases so that there a…
d5bd770 
…re Windows installers
@tcumby
Create the defauilt conan profile
af41410
@tcumby
Drop the Ubuntu version to 20.04
3ba551b
@tcumby
Hopefully fix the libtmpl header inclusion
1de8411
@tcumby
Add setup of FASM
d2abcbf
@tcumby
Create a variable for the parent dir of the libtmpl source
f095cfd
@tcumby
Typos ...
4d5c18c
@tcumby
Add a missing include directory
79897cc
@tcumby
Retrieve FASM for Ubuntu builds
3a6bf7f
@tcumby
Add more libtmpl include dirs
3bac05d
@tcumby
Add more libtmpl include dirs
2505d34
@tcumby
Restrict cmake pipeline to python versions that can install all packages
d0b31b6
@ryanmaguire
Copy link
Collaborator

ryanmaguire commented May 9, 2023 via email

@tcumby
Copy link
Author

tcumby commented May 20, 2023

Hi Ryan,

No worries. rss_ringoccs and libtmpl are a terrific amount of work!

CMake 3.20 is the minimum, but since we support macOS we may need to increase that to 3.24 as XCode 14 has change a number of details of its project format.

Best regards,
Ty

@ryanmaguire ryanmaguire force-pushed the master branch 3 times, most recently from f8e08da to 7858df1 Compare July 15, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcumby @ryanmaguire @RichardGFrench