Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: Add tomli to doc build req #373

Closed
wants to merge 2 commits into from

Conversation

pllim
Copy link

@pllim pllim commented Jun 7, 2023

Just trying to narrow down what broke the docs as reported in astropy/sphinx-astropy#61

😬

@pllim
Copy link
Author

pllim commented Jun 7, 2023

@mkelley , can you pls approve the Actions? 🙏

mkelley
mkelley previously approved these changes Jun 7, 2023
@mkelley mkelley self-requested a review June 7, 2023 18:17
@pllim
Copy link
Author

pllim commented Jun 7, 2023

Ugh nvm... I think I found the reason and the fix is indeed upstream in sphinx-astropy. For whatever reason, pip was choking on the requirement name "v2". Maybe it is some obscure bug they finally fixed in Python 3.11. I will have to make another release upstream.

@mkelley
Copy link
Member

mkelley commented Jun 7, 2023

@pllim Our infrastructure got stale. This probably should be based off of #370

@pllim pllim closed this Jun 7, 2023
@pllim pllim deleted the patch-1 branch June 7, 2023 18:19
@mkelley
Copy link
Member

mkelley commented Jun 7, 2023

Got it, thanks for looking into it!

@pllim
Copy link
Author

pllim commented Jun 7, 2023

Thanks for reporting this! It was an oversight on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants