Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFDL MP slow/fast processes cleanup work #118

Closed
climbfuji opened this issue Jul 10, 2018 · 3 comments
Closed

GFDL MP slow/fast processes cleanup work #118

climbfuji opened this issue Jul 10, 2018 · 3 comments
Assignees

Comments

@climbfuji
Copy link
Collaborator

(1) gfdl_cloud_microphys.F90, gfdl_fv_sat_adj.F90 and gfdl_fv_sat_adj_pre.F90 still use constants imported from other modules, these should come in via the argument list

(2) in gfdl_fv_sat_adj.F90, a preprocessore directive testing for the host model identifier is used to determine whether to open an OpenMP parallel region or not. Ideally, one would test using OpenMP code if the calling function already opened a parallel region or not.

@climbfuji climbfuji self-assigned this Jul 10, 2018
@climbfuji
Copy link
Collaborator Author

(3) The CCPP version of GFDL MP crashes in NEMSfv3gfs when do_sat_adj is set to .false. I believe this has to do with the initialization:

   if (Atm(mytile)%flagstruct%do_sat_adj) then
      ! Initialize fast physics
      call ccpp_physics_init(cdata, group_name="fast_physics", ierr=ierr)
      if (ierr/=0) then
         call mpp_error (FATAL,' atmosphere_dynamics: error in ccpp_physics_init')
      end if
   end if

This block in atmosphere.F90 is responsible for the fast physics init, which also calculates the lookup tables that are used in the standard-physics gfdl_cloud_microphysics.F90.

@climbfuji
Copy link
Collaborator Author

(3) is solved, (1) is partially solved and will be addressed in #104. (2) is not yet solved, requires to know how to use OpenMP pragmas to detect if inside a parallel region or not.

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
Update .gitmodules and submodule pointer for ccpp-physics for code re…
MicroTed pushed a commit to MicroTed/ccpp-physics that referenced this issue Oct 23, 2023
@climbfuji
Copy link
Collaborator Author

Closing this due to a lack of activity here, but a lot of activity adding new versions of the scheme,

@climbfuji climbfuji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant