-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFDL MP slow/fast processes cleanup work #118
Comments
(3) The CCPP version of GFDL MP crashes in NEMSfv3gfs when do_sat_adj is set to .false. I believe this has to do with the initialization:
This block in atmosphere.F90 is responsible for the fast physics init, which also calculates the lookup tables that are used in the standard-physics gfdl_cloud_microphysics.F90. |
(3) is solved, (1) is partially solved and will be addressed in #104. (2) is not yet solved, requires to know how to use OpenMP pragmas to detect if inside a parallel region or not. |
Update .gitmodules and submodule pointer for ccpp-physics for code re…
add dlw,dsw inst to cpllnd block
Closing this due to a lack of activity here, but a lot of activity adding new versions of the scheme, |
(1) gfdl_cloud_microphys.F90, gfdl_fv_sat_adj.F90 and gfdl_fv_sat_adj_pre.F90 still use constants imported from other modules, these should come in via the argument list
(2) in gfdl_fv_sat_adj.F90, a preprocessore directive testing for the host model identifier is used to determine whether to open an OpenMP parallel region or not. Ideally, one would test using OpenMP code if the calling function already opened a parallel region or not.
The text was updated successfully, but these errors were encountered: