Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input for LSM ICs in UFS replay. Optimize i/o step. #397

Closed
wants to merge 2 commits into from

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Aug 29, 2023

This PR fixes a bug in how the LSM Initial conditions are set for UFS replay.
Addresses differences seen in #369

@dustinswales
Copy link
Collaborator Author

@grantfirl @mkavulich
The replay CI test is failing because there was a variable name change from the staged UFS output on the DTC server and what was being used by in #369. I will look into whether we need to update our data, or revert the name change in the code.

@XiaSun-Atmos
Copy link

@dustinswales Thanks for preparing this PR. Is this PR ready for me to use, or should I wait until it is committed to the repo? thanks!

@dustinswales
Copy link
Collaborator Author

@XiaSun-Atmos You can use it now if you want, just as long as you're aware that it may change slightly during the review process.

@grantfirl
Copy link
Collaborator

@dustinswales I'd like to work on this one. As far as you are aware, this is still needed, right? What kind of testing was done?

@XiaSun-Atmos
Copy link

I used this hotfix for the SCM run with active LSM for the CAPE paper.

@dustinswales
Copy link
Collaborator Author

@grantfirl This PR is superseded by #434 (which has this fix and others needed by the replay)

@dustinswales dustinswales deleted the hotfix_ufsreplay branch July 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants