Contrib data script's wget verbosity #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
dustinswales
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
@scrasmussen Thanks for adding the functionality to pass in the verbosity option.
One request, could we add this to the CI scripts as part of this PR? here and here?
|
@scrasmussen Ignore my last comment. (I forgot that we want it to be "-nv" by default) |
…put devaults to -nv so that the Github Actions output won't be filled with the wget download status. This will make debugging failed testcases easier
scrasmussen
force-pushed
the
input-data-silent-wget
branch
from
fff39c0
to
d6ee840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Github Actions logs are being filled up with output from the
wgetdownload status bar.Description of Changes
Added ability to turn on verbose wget output. Wget output defaults to
-nvso that the Github Actions output won't be filled with the wget download status. This will make debugging failed testcases easier.Since I was adding command line arguments I also added
--helpoption.Question for Reviewers
Some of the script have
set -exand some have it commented out. Should we default to the same behavior for all the scripts?Tests Conducted:
Tested scripts by hand.