Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#92 #104

Merged
merged 4 commits into from
Jan 16, 2024
Merged

UFS-dev PR#92 #104

merged 4 commits into from
Jan 16, 2024

Conversation

grantfirl
Copy link
Collaborator

Identical to NOAA-EMC#681

Contains changes from #103 until it is merged.

SamuelTrahanNOAA and others added 2 commits August 22, 2023 09:42
…#681)

* Changes to logging and initialization of the CLM Lake Model.

1. Use ice thickness hice(i) to find the level in the lake where ice is
   zero.
2. Do not allow lake temperature to be below freezing point if there is
   no ice.
3. If there is no snow or ice, do not allow surface lake temperature to
   be below freezing point.
   These changes fixed the problem with large errors in the energy budget
   at the beginning of the cold-start run with lakes.
4. Added flag to turn on debug print statements in the CLM lake model.

* merge ccpp-physics NCAR#91 (UFS-SRW v3.0.0 SciDoc updates)
This was referenced Nov 2, 2023
Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once submodule is updated

@grantfirl grantfirl merged commit 84245dd into NCAR:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants