daylight_fao56

[cyschneck]

PR Summary

Add Meteorology max_daylight geocat function to resolve NCL daylight_fao56 function

Covers:

• daylight_fao56

Related Tickets & Documents

Closes #104

PR Checklist

General

• PR includes a summary of changes
• Link relevant issues, make one if none exist
• If adding a new page, select which type:
  • NCL Entry
  • Receipt

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions]

Meowdy! See your PR preview:
🔍 Git commit SHA: f4ab11e
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/115

[cyschneck]

Combined dewtemp and daylight functions into a single NCL entry, which will eventually include additional meteorology functions

[jukent]

@cyschneck I won't be able to look at this until Monday.

[kafitzgerald]

A few suggestions, but overall this looks good.

The receipt is a little hard to read, but I think a good bit of that is from the formatting which is probably inherited from other receipts and refactoring that is beyond the scope of this PR.

[jukent]

Approved, pending @kafitzgerald 's suggestions.

I want to make sure we're remembering all of the formatting and other comments we've made in PRs that are outside the scope of those PRs

[kafitzgerald]

The pre-commit failure here looks like it's the same as on NCAR/geocat-examples#618.

I ended up just commenting docformatter out for now in the pre-commit config and logging an issue to add it back once the new release is out to address this there.

[cyschneck]

The pre-commit failure here looks like it's the same as on NCAR/geocat-examples#618.

I ended up just commenting docformatter out for now in the pre-commit config and logging an issue to add it back once the new release is out to address this there.

Will do