Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site structure #134

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Update site structure #134

merged 8 commits into from
Oct 25, 2024

Conversation

kafitzgerald
Copy link
Collaborator

PR Summary

Updates the site structure.

Closes #54

I like the general structure and language a bit better with this, but I'm not so sure about have the notebooks missing from the toc. Formatting that cleanly was proving challenging though so I figured I'd at least put this up in draft mode for initial feedback.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Oct 25, 2024

Meowdy! See your PR preview:
🔍 Git commit SHA: 8a04629
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/134

@kafitzgerald kafitzgerald marked this pull request as ready for review October 25, 2024 18:15
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for tackling this

@anissa111
Copy link
Member

I'm going to merge this now, as the goal was to get this in before the ESDS presentation on Monday and I am going to use this to make screen recordings for the slides.

I think this is a solid PR and we can iterate on further improvements after Monday.

@anissa111 anissa111 merged commit b87d09a into NCAR:main Oct 25, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@anissa111 anissa111 mentioned this pull request Oct 26, 2024
anissa111 added a commit that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GA-1527] Proposed structure clarification (pulled from #44)
2 participants