Specx workflow and NCL receipt

[jukent]

PR Summary

Demonstrates how to use the scipy.signal module for spectral analysis and a 1-to-1 NCL receipt.

Related Tickets & Documents

Closes NCAR/geocat-comp#124

PR Checklist

General

• PR includes a summary of changes
• Link relevant issues, make one if none exist

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions]

Meowdy! See your PR preview:
🔍 Git commit SHA: c652a4f
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/39

[jukent]

I might be missing a couple places where I have to list these notebooks in order for them to visible. Do we have documentation on that yet?

[anissa111]

I might be missing a couple places where I have to list these notebooks in order for them to visible. Do we have documentation on that yet?

Ahh, yeah. So ultimately I want to automate a lot of that, but for now, some of it is in the contributors guide.

[cyschneck]

There are two main notebooks here: one that lives under data_analysis (data_analysis/spectral_analysis.ipynb) and the receipt and notebook that live as NCL files (ncl/NCL_spectral_analysis.ipynb and ncl/receipts/NCL_receipt_spectral_alaysis)

So spectral analysis should show up on the sidebar in two places, @anissa111 correct? One under Applications > Data Analysis and the other under NCL Applications

[jukent]

Still unclear on the repetition of entries in NCL_index and NCL_applications

[anissa111]

Still unclear on the repetition of entries in NCL_index and NCL_applications

Right, I think I'm also confused about what's going on here.

There are two main notebooks here: one that lives under data_analysis (data_analysis/spectral_analysis.ipynb) and the receipt and notebook that live as NCL files (ncl/NCL_spectral_analysis.ipynb and ncl/receipts/NCL_receipt_spectral_alaysis)

So spectral analysis should show up on the sidebar in two places, @anissa111 correct? One under Applications > Data Analysis and the other under NCL Applications

@cyschneck, are you asking if the same physical notebook should be linked in two places (no, in my opinion) or are you asking if spectral analysis content should be in multiple different categories?

[cyschneck]

@anissa111, because there are two separate notebooks, they should both appear separately on the side bar? So I am asking are you asking if spectral analysis content should be in multiple different categories? Since this covers both a Python applications notebook and an NCL to Python notebook

[anissa111]

Getting back to this, I think it would be worth doing some higher-level updates before getting into some more fine-grained feedback.

I know it's been a minute since this has seen attention, so here are the things I noticed need updated from team discussions about since last time.

• Remove NCL references from python content (applications/data_analysis/spectral_analysis.ipynb)
• Take a pass through plotting/viz sections for non-essential lines (like plt.tight_layout(), probably plt.show(), possibly figsize=(...) if it doesn't effect the readability)
• Consider combining ncl/ncl_entries/specx_anal.ipynb and ncl/ncl_entries/specxy_anal.ipynb NCL entries and possibly reconfigure to include NCL content from the python content/receipt and to be more in line with the NCL template and other NCL entries.
• Make the receipt (ncl/receipts/specx_anal.ipynb) more consistent with receipt template and other reciepts (in the way of less narrative content, more testing, etc)

[anissa111]

Ah, gosh. I meant for that to show up as a commented review, my bad. I'm going to remove myself as a requested reviewer so that I can be re-requested/notified when it's is ready for another look.

[jukent]

figsize() and tightlayout() does affect readability on the subplots.

[anissa111]

Also, I'm seeing some more of those mathjax things here:

[kafitzgerald]

Overall this is looking really good.

Some more general comments/questions (more specific comments inline):

• It looks like the outputs are still stored stored on this though - I think the plan is to clear those now that there's infra to run the notebooks.
• It looks like specxy_anal is in the NCL Index, but not the receipts. I assume that's an item for later, but wanted to double check.