Inverse/Hyperbolic Trig Functions and NCL Receipt #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyschneck
added
ncl receipt
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Meowdy! See your PR preview: |
kafitzgerald
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Looks good other than the notebook diffs and I don't think that's a problem for now - just a nice to have for later.
I did notice the assertion statements don't seem to show outputs (or maybe I missed something). The diffs are visible and the important part is that they're there to run so I think it's all good.
| @@ -76,7 +80,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "execution_count": 47, | |||
anissa111
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Inverse and Hyperbolic trig functions. To be added to existing trig functions notebook
Related Tickets & Documents
Closes #68
PR Checklist
General