-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ncl dewtemp_trh outputs #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's fairly easy to programmatically generate and check inputs / outputs for this function. Can this be thinned down a bit and live in GeoCAT applications? I feel like that's what we did for some of the other functions.
Totally possible I missed something here too (apparently I did).
Outside of the conversation on location that I'll leave to our slack conversation, I have a small suggestion. Assuming it would be minimal effort, I think it might be useful to include the corresponding inputs in the file as additional columns. As in, outputting columns of temp, rh, and then the calculated dewtemp. This would make it easier to recreate and compare over in geocat-applications, as well. Also, the ncl script itself should live over in geocat-applications. |
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registry file needs an update, but otherwise looks good.
Adds
dewtemp_trh
output values to use fordewtemp
in applications (NCAR/geocat-applications#100)