Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ncl dewtemp_trh outputs #76

Merged
merged 4 commits into from
Aug 30, 2024
Merged

add ncl dewtemp_trh outputs #76

merged 4 commits into from
Aug 30, 2024

Conversation

cyschneck
Copy link
Contributor

Adds dewtemp_trh output values to use for dewtemp in applications (NCAR/geocat-applications#100)

@cyschneck cyschneck self-assigned this Aug 28, 2024
@cyschneck cyschneck marked this pull request as ready for review August 28, 2024 19:08
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's fairly easy to programmatically generate and check inputs / outputs for this function. Can this be thinned down a bit and live in GeoCAT applications? I feel like that's what we did for some of the other functions.

Totally possible I missed something here too (apparently I did).

@anissa111
Copy link
Member

Outside of the conversation on location that I'll leave to our slack conversation, I have a small suggestion. Assuming it would be minimal effort, I think it might be useful to include the corresponding inputs in the file as additional columns. As in, outputting columns of temp, rh, and then the calculated dewtemp. This would make it easier to recreate and compare over in geocat-applications, as well.

Also, the ncl script itself should live over in geocat-applications.

@cyschneck
Copy link
Contributor Author

Outside of the conversation on location that I'll leave to our slack conversation, I have a small suggestion. Assuming it would be minimal effort, I think it might be useful to include the corresponding inputs in the file as additional columns. As in, outputting columns of temp, rh, and then the calculated dewtemp. This would make it easier to recreate and compare over in geocat-applications, as well.

Also, the ncl script itself should live over in geocat-applications.

Removed dewtemp_trh.ncl and included the tk/rh as values in a comma separated columns with dewtemp

Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry file needs an update, but otherwise looks good.

registry.txt Outdated Show resolved Hide resolved
@kafitzgerald kafitzgerald merged commit d5ffcb7 into NCAR:main Aug 30, 2024
@cyschneck cyschneck deleted the dewtemp branch August 30, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants