Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency bug fix for the new roll-out and metadata loader #60

Merged
merged 16 commits into from
Jul 15, 2024
Merged

Conversation

yingkaisha
Copy link
Collaborator

@yingkaisha yingkaisha commented Jul 11, 2024

New feature

  • Enable customizable metadata file from conf['predict']
  • Can skip metadata if no info is provided
  • Can specify a subset of variables to save
  • Updated FuXi and crossformer configs based on the new roll-out feature

Bugfix

  • Fixed the netCDF4 encoding error of time coordinate.
  • Fixed string to float conversion error in the old era5.yml, the original era5.yml is preserved as era5_old.yml.
  • Fixed xarray slicing error.
  • Fixed metadata loading problem and replaced it with customized metadata location in conf['predict']
  • Fixed pbs.py; it will always remove the old launch.sh and model.yml, and copy/generate the new ones in conf['save_loc']. These operations will have print-outs when running rollout_to_netcdf.py and train.py

@yingkaisha yingkaisha requested review from djgagne and jsschreck July 11, 2024 14:53
@yingkaisha
Copy link
Collaborator Author

Proposed a better fix for the time encoding problem, c.f. pydata/xarray#3739

@jsschreck jsschreck merged commit 2fffa66 into main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants