Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1716-mn-reindex #1738

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Feature 1716-mn-reindex #1738

merged 13 commits into from
Nov 29, 2023

Conversation

taojing2002
Copy link
Contributor

The branch focuses on moving the reindex action from the old Metacat api to the new DataONE MN.admin api.

src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
src/edu/ucsb/nceas/metacat/dataone/MNodeService.java Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to MNodeServiceIT?

if (resourceMapFormatList != null && resourceMapFormatList.size() > 0) {
for (String format : resourceMapFormatList) {
if (format != null && !format.trim().equals("")) {
if (firstTime) {
sql = sql + " where object_format !='" + format + "'";
sql.append(" where object_format !='" + format + "'");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has string concatenation

firstTime = false;
} else {
sql = sql + " and object_format !='" + format + "'";
sql.append(" and object_format !='" + format + "'");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has string concatenation

if (resourceMapFormatList != null && resourceMapFormatList.size() > 0) {
boolean firstTime = true;
for (String format : resourceMapFormatList) {
if (format != null && !format.trim().equals("")) {
if (firstTime) {
sql = sql + " where object_format ='" + format + "'";
sql.append(" where object_format ='" + format + "'");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has string concatenation

firstTime = false;
} else {
sql = sql + " or object_format ='" + format + "'";
sql.append(" or object_format ='" + format + "'");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has string concatenation

@taojing2002 taojing2002 merged commit 506336b into develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants