Make sure we do not serialize empty EMLParty nodes to the EML document.

Also fixed a bug in the EMLParty validation where an old function was being called that has since been renamed.
NCEAS · Nov 6, 2017 · d903395 · d903395
1 parent 69bfe44
commit d903395
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/metacatui/src/main/webapp/js/models/metadata/eml211/EML211.js b/metacatui/src/main/webapp/js/models/metadata/eml211/EML211.js
@@ -743,13 +743,17 @@ define(['jquery', 'underscore', 'backbone', 'uuid',
            				insertAfter = this.getEMLPosition(eml, type);           			    
            			}
 
-           			//Insert the party DOM at the insert position
-                    if ( insertAfter && insertAfter.length ) {
-	           			insertAfter.after(party.updateDOM());                        
-                    }
-           			//If an insert position still hasn't been found, then just append to the dataset node
-                    else{
-                    	$(eml).find("dataset").append(party.updateDOM());
+           			//Update the DOM of the EMLParty
+           			var emlPartyDOM = party.updateDOM();
+
+           			//Make sure we don't insert empty EMLParty nodes into the EML
+           			if( $(emlPartyDOM).children().length ){
+           				//Insert the party DOM at the insert position
+                        if ( insertAfter && insertAfter.length )    			
+                        	insertAfter.after(emlPartyDOM); 
+                        //If an insert position still hasn't been found, then just append to the dataset node
+                        else
+                        	$(eml).find("dataset").append(emlPartyDOM);
                     }
 
 	           	}, this);

diff --git a/metacatui/src/main/webapp/js/views/metadata/EML211View.js b/metacatui/src/main/webapp/js/views/metadata/EML211View.js
@@ -547,7 +547,7 @@ define(['underscore', 'jquery', 'backbone',
 	    		this.renderPerson(null, partyType);
 	    	}
 	    	else{
-	    		partyForm.find(".eml-party").data("view").showRequired();
+	    		partyForm.find(".eml-party").data("view").showValidation();
 	    	}
 	    },