Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation errors with schema.org #1440

Closed
4 tasks done
mbjones opened this issue Jun 30, 2020 · 1 comment
Closed
4 tasks done

validation errors with schema.org #1440

mbjones opened this issue Jun 30, 2020 · 1 comment
Assignees
@amoeba
Labels
bug jsonld Adding JSON-LD to MetacatUI pages
Milestone
2.13.0

Comments

@mbjones
Copy link
Member

mbjones commented Jun 30, 2020 •
edited by amoeba
Loading

Describe the bug
Our schema.org entries do not validate using the in-progress validator by science on schema.org. While that is in flux, there are still some clear items that should be fixed:

  • Ensure the schema.org namespace includes its trailing slash
  • add the required sameAs property
  • add the required version property
  • add the required isAccessibleForFree property

To Reproduce
Steps to reproduce the behavior:

  1. Copy the JSON-LD from any dataset (e.g., https://arcticdata.io/catalog/view/doi%3A10.18739%2FA2MG7FW5P)
  2. Paste the JSON-LD into the validator at https://grbf0pbqz1.execute-api.us-east-1.amazonaws.com/dev/edit
  3. See errors. The first error on the namespace hides the others. Once you fix the first one, the other errors will show up.

Expected behavior
The schema.org should validate without errors. For the document above, I changed the following and it validates:

 "@vocab":"http://schema.org/"
 "sameAs":"https://doi.org/10.18739/A2MG7FW5P",
 "isAccessibleForFree": true,
 "version":"doi:10.18739/A2MG7FW5P",

Related to: Issue #1437
@mbjones mbjones added bug jsonld Adding JSON-LD to MetacatUI pages labels Jun 30, 2020
amoeba added a commit that referenced this issue Jul 15, 2020
@amoeba
Update properties in MetadataView's embedded JSON-LD
269d3a0 
Closes #1440

Adds three properties that are taken from science-on-schema guidance at https://github.com/ESIPFed/science-on-schema.org/blob/master/guides/Dataset.md which included:

- sameAs for records with a DOI pointing at their DOI.org landing page
- version with the identifier's value
- isAccessibleForFree = true for all records
@amoeba amoeba added this to the 2.13.0 milestone Jul 15, 2020
@amoeba
Copy link
Contributor

amoeba commented Jul 15, 2020 •
edited
Loading

Done in 269d3a0.

I added sameAs just for identifiers that appear to be DOIs, added version and isAccessibleForFree for all.

PS: The validator is down so I can't validate my changes so we'll hope they work.

@amoeba amoeba closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoeba amoeba

Labels
bug jsonld Adding JSON-LD to MetacatUI pages
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@amoeba @mbjones