Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics/Profile: "Latest Updates" plot label colors are illegible and flash when hovering #1545

Closed
mburrus opened this issue Oct 19, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@mburrus
Copy link

mburrus commented Oct 19, 2020

Describe the bug
When on a data repository's profile page (or the repository's summary page), the "Latest Updates" plot label appears when hovering over a plot point, however, it has a dark navy background and dark mustard text color, making it very hard to read. Also, depending on your placement of the mouse while hovering, the label may flash aggressively.

Note this is not an issue for customizable data portal metrics.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://data.ess-dive.lbl.gov/profile or https://arcticdata.io/catalog/profile
  2. Scroll down to "Latest Updates" graph
  3. Hover mouse over any plot point
  4. See error

Expected behavior
When hovering over a plot point in the "Latest Updates" plot, I expect to see a static label in some combination of contrasting colors (I think it used to be navy blue and white for a time?).

Screenshots
Screen Shot 2020-10-19 at 12 10 00 PM

Desktop:

  • OS: macOS Catalina 10.15.6
  • Browser: Chrome
  • Version: Version 86.0.4240.80
@mburrus mburrus added the bug label Oct 19, 2020
@mbjones
Copy link
Member

mbjones commented Oct 19, 2020

I can see this problem on Firefox 81.0 as well, so it is not browser-specific.

@mbjones mbjones added this to the 2.13.3 milestone Oct 19, 2020
@laurenwalker
Copy link
Member

Thanks, I will take a look at this

@laurenwalker
Copy link
Member

I've fixed this by increasing the size of each data point when you are hovering on it, so it's harder to mouseout. I also added a quick delay to hiding the label so it's still visible for 300 milliseconds after leaving the data point.

fix.gif

The text color was coming from all the theme CSS files, so I removed those. You'll want to make sure your ESS-DIVE theme doesn't have that same CSS rule in your theme CSS. (.line-chart-label.text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants