Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Google maps with Cesium #1720

Closed
robyngit opened this issue Apr 14, 2021 · 4 comments
Closed

Replace Google maps with Cesium #1720

robyngit opened this issue Apr 14, 2021 · 4 comments
Assignees
@laurenwalker @robyngit
Labels
ADC CI-16 Geospatial search improvements (ADC deliverable) arctic data center cesium enhancement Epic
Milestone
2.25.0

Comments

@robyngit
Copy link
Member

robyngit commented Apr 14, 2021 •
edited by laurenwalker
Loading

Replace the Google map that is currently used in the DataCatalogView and DataCatalogViewWithFilters with a Cesium map

Related issues: #1436, #1514, #1520
@robyngit robyngit self-assigned this Apr 14, 2021
robyngit added a commit that referenced this issue Apr 14, 2021
@robyngit
Show Cesium with geohash grid in DataCatalogView [WIP]
bc3c164 
- Add an initial model for the Cesium map with a default "home position" and geohash functions
- Render the Cesium map in the DataCatalogView in place of the Google map
- Display the geohash grid and update when the user zooms or pans
- This is a WIP: the map does not yet interact with the search

Relates to issue #1720
@mbjones
Copy link
Member

mbjones commented Apr 14, 2021

Sounds good. I think for a while at least this should be a configurable choice, not outright removal of the Google Map options. If most themes move to using Cesium, then we could deprecate the google maps support and remove it in a later release, but not without sufficient notice and discussion with various MetacatUI deployments.

@laurenwalker
Copy link
Member

Let's do the development for this on a separate branch than the Cesium work for portals and PDG. Keeping that development work on different branches will prevent us from having to delay releases until both are done.

robyngit added a commit that referenced this issue May 3, 2021
@robyngit
Make the use of Cesium maps in the search catalog configurable
9675e69 
- The Google map is now shown by default

Relates to issue #1720
@robyngit
Copy link
Member Author

robyngit commented May 3, 2021

The development for this issue is now in the branch named feature-#1720-cesium-data-catalog, and the choice of whether to use Google maps or Cesium in the search catalog is now configurable.

robyngit added a commit that referenced this issue May 5, 2021
@robyngit
Make home position configurable in CesiumModel
fa039f8 
- Add functions to navigate home and get current position in the CesiumView

Relates to issue #1720, #1724
robyngit added a commit that referenced this issue Oct 1, 2021
@robyngit
Switch CesiumView to CesiumWidgetView in catalog
eb275b4 
- The DataCatalogView was still referencing the CesiumModel and the CesiumView which we will no longer use

Relates to #1720
@laurenwalker
Copy link
Member

I converted this to an Epic since this work will likely happen in stages. @robyngit Feel free to add issues for individual steps, such as planning, design, and the coding/implementation steps.

@laurenwalker laurenwalker changed the title Replace Google map with Cesium map Replace Google maps with Cesium Dec 21, 2021
@robyngit robyngit mentioned this issue Dec 22, 2021
Closed
@laurenwalker laurenwalker mentioned this issue Jan 3, 2022
Closed
robyngit added a commit that referenced this issue Jan 12, 2022
@robyngit
Merge branch 'develop' into feature-#1720-cesium-data-catalog
9da7824
@robyngit robyngit mentioned this issue Jan 15, 2022
Closed
robyngit added a commit that referenced this issue Jan 19, 2022
@robyngit
Fix 2 bugs in CesiumWidgetView
2f5c14c 
- Fix issue with getCameraPosition where height was not calculated correctly
- Fix bug where updateViewExtent showed an error message when edge points couldn't be found

Relates to #1720
robyngit added a commit that referenced this issue Jan 31, 2022
@robyngit
Merge branch 'develop' into feature-#1720-cesium-data-catalog
eef0f7d
robyngit added a commit that referenced this issue Feb 7, 2022
@robyngit
Merge branch 'develop' into feature-#1720-cesium-data-catalog
0fcf55e
robyngit added a commit that referenced this issue Feb 8, 2022
@robyngit
Merge branch 'develop' into feature-#1720-cesium-data-catalog
296a7d0
@laurenwalker laurenwalker self-assigned this Mar 17, 2022
robyngit added a commit that referenced this issue Mar 17, 2022
@robyngit
Merge branch 'develop' into feature-#1720-cesium-data-catalog
3487c74
@robyngit robyngit removed their assignment Mar 18, 2022
@laurenwalker laurenwalker mentioned this issue Apr 14, 2022
Closed
laurenwalker added a commit that referenced this issue May 20, 2022
@laurenwalker
First iteration of DataCatalog refactor and replacing Google Maps wit…
ea5103d 
…h Cesium. #1720
laurenwalker added a commit that referenced this issue Jul 8, 2022
@laurenwalker
Merge branch 'feature-replace-gmaps-1720' into feature-#1720-replace-…
ce6a8ac 
…gmaps
laurenwalker added a commit that referenced this issue Jul 8, 2022
@laurenwalker
Add annotation filter to default filter group so it shows up in searc…
18c8396 
…h views unless explicitly omitted. Related to #1720 with the DataCatalogView/CatalogSearchView refactor.
laurenwalker added a commit that referenced this issue Jul 8, 2022
@laurenwalker
Add json-ld to new CatalogSearchView using DataCatalogView.getLinkedD…
a9f2a2e 
…ata() code. Related to #1720
laurenwalker added a commit that referenced this issue Jul 8, 2022
@laurenwalker
Use the "data" route for the new CatalogSearchView. Soft deprecate th…
77bb226 
…e DataCatalogView. Related to #1720
robyngit added a commit that referenced this issue Apr 6, 2023
@robyngit
Fix geohash geoJSON & getting hashes for filter
6bc3a13 
- Fix coordiante order in creating Geohash feature
- Fix bug where SpatialFilter failed when view extent crossed the antimeridian
- The geohashes are finally drawn correctly on the map and the correct hashstrings for the view area are identified for the search! 🎉

Relates to #1720
robyngit added a commit that referenced this issue Apr 10, 2023
@robyngit
Fix bug in filters-search connector
fd48825 
Relates to #1720
robyngit added a commit that referenced this issue Apr 12, 2023
@robyngit
Improvements to Geohash appearance
f9b0aae 
- Enable adding outlines to GeoJSON
- Enable setting colors with alpha values in Cesium layer color palettes
- Enable setting the min and max for a color palette dynamically
- Use all of these features to set reasonable defaults for the Cesium Geohash layer

Issues #2123, #2124, #2125, #1720
robyngit added a commit that referenced this issue Apr 17, 2023
@robyngit
Render geohash count labels
9190bfd 
Issues #2066, #1720
robyngit added a commit that referenced this issue Apr 18, 2023
@robyngit
Fix zooming behavior & feature info bugs in Cesium
b4b745d 
Problems found during testing of changes made for issue #1720
robyngit added a commit that referenced this issue Apr 19, 2023
@robyngit
Add Map opts for hiding home button & layer list
5bff0df 
Issue #1720
robyngit added a commit that referenced this issue Apr 19, 2023
@robyngit
Improvements to catalog search styles [WIP]
70fde2b 
Issue #1720
robyngit added a commit that referenced this issue Apr 20, 2023
@robyngit
Fix styles in new catalog & routing to old catalog
d6b82d5 
- Use all new classes in the Catalog Search View to resolve CSS conflicts and to make styling between themes, and between the old and new catalog, consistent
- Move all Catalog Search styles out of the common CSS file to the catalog search CSS file
- Improve the layout and styling of the catalog
- Fix an issue with routing to the old data catalog view when the mode is specific in the URL

Issues #1720, #2065
robyngit added a commit that referenced this issue May 4, 2023
@robyngit
Make CesiumGeohash compatible with new methods +
be0f061 
Other minor fixes and improvements:
- Add configurable collection-wide min and max precision values in Geohashes (set max to 9 rather than 6)
- Always validate precisions and bounds in methods that use them in Geohashes collection
- Account for bounding boxes that cross the antimeridian or have north < south when calculating area
- Fix issue where the search results remained in "loading" state when the search was cancelled (e.g. the request URL didn't change, happens when the Cesium camera view has not changed sufficiently)
- Decrease limit of number of geohashes in spatial filter to respect Solr's boolean clauses limit
- Fix issue where pager was hidden when there were 25-50 results
- Remove old CesiumGeohashes view
- Remove unused methods from CesiumGeohash model & Geohashes collection

Issues: #2119, #1720
robyngit added a commit that referenced this issue May 5, 2023
@robyngit
Fix calculation of whether geohashes are in view
0334188 
- Account for view extents that cross the prime meridian
- Tweak the max num of geohashes to display in Geohash layer

Issues: #2119, #1720
robyngit added a commit that referenced this issue May 5, 2023
@robyngit
UI enhancements for the new CatalogSearchView
e8ba9ae 
Allow collapsing the filters panel, other minor improvements.

Relates to #1720
robyngit added a commit that referenced this issue May 5, 2023
@robyngit
Make filters optionally collapsible
a797bb2 
- Set them to collapsible for the new catalog view
- Fix bugs with the toggleFilter and BooleanFilter
- Update the default search filters

Issues #1720, #1520
@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
@robyngit robyngit added ADC CI-16 Geospatial search improvements (ADC deliverable) arctic data center labels May 17, 2023
robyngit added a commit that referenced this issue May 22, 2023
@robyngit
Add tests for Geohashes collections
53c5e64 
Plus minor modifications/fixes to Geohashes

Issue #1720
robyngit added a commit that referenced this issue May 22, 2023
@robyngit
Add tests for Filters-Map connector
5b67204 
Fix the remove spatial filters method

Issue #1720
robyngit added a commit that referenced this issue May 24, 2023
@robyngit
Add rest of tests for Geohash-related map models
a7a9f12 
- Add types to models
- Minor fixes found during testing

Issue #1720
robyngit added a commit that referenced this issue May 25, 2023
@robyngit
Add docs for: CatalogSearchView, Filters, Cesium
d29c21d 
- Add guide for customizing the CatalogSearchView
- Add guide for configuring Cesium in portals
- Update the general Cesium guide
- Other minor doc updates
- Minor CSS tweak

Issue #1720
robyngit added a commit that referenced this issue May 25, 2023
@robyngit
Add screenshots for CatalogSearchView & sub-views
639fab4 
Issue #1720
robyngit added a commit that referenced this issue May 25, 2023
@robyngit
Add JSDocs @SInCE tags to new methods
f6a993d 
Issue #1720
robyngit added a commit that referenced this issue May 30, 2023
@robyngit
Exclude portals & collections from search results
6ad2fd6 
In new CatalogSearch view

Issue #1720
robyngit added a commit that referenced this issue May 30, 2023
@robyngit
Fix minor bug with DateFilterView
4df5a58 
Prevent input values from getting cleared when user presses "Enter" in the min and max inputs.

Issue #1720
robyngit added a commit that referenced this issue Jun 5, 2023
@robyngit
Add metrics & map icons to the search results list
ed827d4 
Add the logic to create and update a metricsModel in the new SearchResultsView.

Issue #1720
robyngit added a commit that referenced this issue Jun 20, 2023
@robyngit
Allow Geohash layer to be hidden by user
d5a13f8 
Issue #1720
@robyngit robyngit mentioned this issue Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenwalker laurenwalker

@robyngit robyngit

Labels
ADC CI-16 Geospatial search improvements (ADC deliverable) arctic data center cesium enhancement Epic
Projects
Arctic Data Center Management Plan Deliverables
Status: Done
Milestone
2.25.0
Development

No branches or pull requests
3 participants
@mbjones @laurenwalker @robyngit