Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Formantic-UI to newest version (2.9+) #2253

Closed
robyngit opened this issue Jan 25, 2024 · 0 comments · Fixed by #2477
Closed

Update Formantic-UI to newest version (2.9+) #2253

robyngit opened this issue Jan 25, 2024 · 0 comments · Fixed by #2477
Assignees
@robyngit
Labels
ADC CI-15 Editing measurement semantics (ADC deliverable) arctic data center enhancement special rule UI Special interfaces used for abstracted rules in the Query Builder
Milestone
2.31.0

Comments

@robyngit
Copy link
Member

Formantic-UI is a community fork of Semantic-UI, which we use mainly for the searchable dropdown interfaces (e.g. in the query builder). We are currently using Formantic v 2.8.6 released in June 2020. The latest version is 2.9.3 released in September 2023. It not only has a number of bug fixes, but also a new dropdown feature which will help us adapt dropdowns developed for the query builder to be used in other parts of MetacatUI (see #1693 and #1654).

In initial tests, there seem to be more breaking changes than listed in the changelog. For example, the dropdown's onChange event now happens before the onLabelCreate event, which causes errors in how we're using the element. Changes to the associated Formantic CSS files causes the dropdowns to be irregularly sized and positioned. We'll need to spend some time to figure out how to fix these issues, and any others that come up in testing.
@robyngit robyngit added enhancement special rule UI Special interfaces used for abstracted rules in the Query Builder arctic data center ADC CI-15 Editing measurement semantics (ADC deliverable) labels Jan 25, 2024
@robyngit robyngit added this to the 2.28.0 milestone Jan 25, 2024
@robyngit robyngit self-assigned this Jan 25, 2024
robyngit added a commit that referenced this issue Jan 25, 2024
@robyngit
Initial progress updating Formantic to 2.9.3 [WIP]
2c1d59c 
- Update dropdown.min.js to 2.9.3
- Update SearchableSelectView to accommodate change in order of onLabelCreate and onChange events
- Still need to address new errors
- Still need to update transition.min.js, api.min.js, and associated CSS files

Issue #2253
@robyngit robyngit modified the milestones: 2.28.0, 2.29.0 Feb 8, 2024
@robyngit robyngit modified the milestones: 2.29.0, 2.30.0 May 6, 2024
robyngit added a commit that referenced this issue Jun 5, 2024
@robyngit
Initial progress updating Formantic to 2.9.3 [WIP]
0a5d865 
- Update dropdown.min.js to 2.9.3
- Update SearchableSelectView to accommodate change in order of onLabelCreate and onChange events
- Still need to address new errors
- Still need to update transition.min.js, api.min.js, and associated CSS files

Issue #2253
@robyngit robyngit modified the milestones: 2.30.0, 2.31.0 Jun 25, 2024
robyngit added a commit that referenced this issue Jul 2, 2024
@robyngit
Fix linting errors in QueryFields collection
eff556b 
Issue #2253
robyngit added a commit that referenced this issue Jul 2, 2024
@robyngit
Fix linting errors in QueryRuleView
e90a552 
Issue #2253
@robyngit robyngit linked a pull request Jul 2, 2024 that will close this issue
Update formantic UI to v2.9 #2477
Merged
@robyngit robyngit removed a link to a pull request Jul 2, 2024
Update formantic UI to v2.9 #2477
Merged
@robyngit robyngit linked a pull request Jul 2, 2024 that will close this issue
Update formantic UI to v2.9 #2477
Merged
robyngit added a commit that referenced this issue Jul 3, 2024
@robyngit
Fix linting errors in SearchableSelectView
1bd8bb8 
Issue #2253
robyngit added a commit that referenced this issue Jul 15, 2024
@robyngit
Add models/collection for Search Select View
a284b87 
- To hold model logic that is currently in the SearchableSelectViews

Issue #2253
robyngit added a commit that referenced this issue Jul 15, 2024
@robyngit
Move some model logic from SearchSelectView to model
7b45dea 
- The following SearchableSelectView options are now handled by the SearchSelect model: 'allowMulti', 'allowAdditions', 'clearable', 'submenuStyle', 'hideEmptyCategoriesOnSearch', 'selected', 'options'
- WIP: Still need to move more logic from view to model

Issue #2253
robyngit added a commit that referenced this issue Jul 17, 2024
@robyngit
Move more logic from SearchSelectView to model
21904f9 
- separator and menu style changes are now handled by the SearchSelect model.

Issue #2253
robyngit added a commit that referenced this issue Jul 17, 2024
@robyngit
Move more logic from SearchSelectView to model
d705ab5 
- separator and menu style changes are now handled by the SearchSelect model.

Issue #2253
robyngit added a commit that referenced this issue Jul 17, 2024
@robyngit
Move the SearchSelect separator to own view
d2aec3d 
- Further modularize the SearchableSelect view by creating a view for the separator elements that listens to and updates the SearchSelect model

Issue #2253
robyngit added a commit that referenced this issue Jul 22, 2024
@robyngit
Clean up & modularize SearchSelectView
7708c63 
- In prep for updating Formantic UI, clean up the searchableSelectView
- Move formantic UI call backs into their own function
- Move classes to constants
- Break methods down into smaller methods
- Fix JSdocs

Issue #2253
robyngit added a commit that referenced this issue Jul 22, 2024
@robyngit
Use constants for classes, selectors in SearchSelect
43cb975 
Misc updates to make the code more DRY

Issue #2253
robyngit added a commit that referenced this issue Jul 22, 2024
@robyngit
Add formanticUI popup; replace SelectSearch tooltips
2cd81a5 
- Add the newest Formantic UI popup module which is very small
- Use in place of Bootstrap tooltip module in SearchableSelectView
- Using this module instead of bootstrap simplifies adding & properly removing tooltips. We can start using this module where we are having issues with the Bootstrap tooltips in other places (see tagged issues below).

Issues #2253, #2319, #1733, #1694, #1682
robyngit added a commit that referenced this issue Jul 23, 2024
@robyngit
Add QueryFieldSelect model; simplify views
2edec80 
- The QueryFieldSearchSelect model handles manipulating the Solr Query Field options for the QueryFieldSeachSelect view
- Move inputLabel and placeHolder text to Search Select models
- Adapt Query Field tooltips to semantic UI popup module
- Simplify the Search Selects code where possible

Issue #2253
robyngit added a commit that referenced this issue Jul 23, 2024
@robyngit
Move AcountSelect logic to model from view
9188461 
Issue #2253
robyngit added a commit that referenced this issue Jul 23, 2024
@robyngit
Clean up & simplify the NodeSelectView
83a7411 
Issue #2253
robyngit added a commit that referenced this issue Jul 24, 2024
@robyngit
Clean up & simplify ObjectFormatSelectView
3c74394 
Issue #2253
robyngit added a commit that referenced this issue Jul 24, 2024
@robyngit
Add tests for new searchSelect models
20a4924 
Issue #2253
robyngit added a commit that referenced this issue Jul 24, 2024
@robyngit
Add unit tests for SearchSelectOptions collection
2c55f81 
Issue #2253
robyngit added a commit that referenced this issue Jul 24, 2024
@robyngit
Minor fixes to QueryFields search select
ab13d75 
Issue #2253
robyngit added a commit that referenced this issue Jul 24, 2024
@robyngit
Update Formantic UI components to 2.9
7813a35 
And fix bugs; simplify the search select

Issue #2253
robyngit added a commit that referenced this issue Jul 25, 2024
@robyngit
Install semantic from npm; build custom dist
dda8a31 
Include README on how to update moving forward

Issue #2253
robyngit added a commit that referenced this issue Jul 25, 2024
@robyngit
Quick fixes to SearchSelect view
801e41d 
Issue #2253
robyngit added a commit that referenced this issue Jul 25, 2024
@robyngit
Rename SearchableSelect to SearchSelect for consistency
57f585b 
issue #2253
robyngit added a commit that referenced this issue Jul 25, 2024
@robyngit
Fix SearchSelect tests; format & lint fixes
560483d 
Issue #2253
@robyngit robyngit closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
ADC CI-15 Editing measurement semantics (ADC deliverable) arctic data center enhancement special rule UI Special interfaces used for abstracted rules in the Query Builder
Projects
Arctic Data Center Management Plan Deliverables
Status: Done
Milestone
2.31.0
Development

Successfully merging a pull request may close this issue.

Update formantic UI to v2.9 NCEAS/metacatui
1 participant
@robyngit