Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with Citation Display #2395

Closed
rushirajnenuji opened this issue May 1, 2024 · 2 comments · Fixed by #2510
Closed

Issues with Citation Display #2395

rushirajnenuji opened this issue May 1, 2024 · 2 comments · Fixed by #2510
Assignees
@rushirajnenuji
Labels
bug citations Related to the CitationView, CitationModel, or Citations collection
Milestone
2.31.0

Comments

@rushirajnenuji
Copy link
Member

Describe the bug
The summary pages in MetacatUI errors out while trying to render citations

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://arcticdata.io/catalog/profile' (or any metrics page)
  2. Scroll tp the Citations section on the stats / metrics page

Expected behavior
Render complete list of Citaitons.

Screenshots
Screenshot 2024-05-01 at 10 54 34

Desktop (please complete the following information):

  • OS: macOS 14
  • Browser Chrome (Version 124.0.X) and Firefox (Version 125.0.3)

Console logs
Screenshot 2024-04-29 at 10 52 38
@rushirajnenuji rushirajnenuji added bug citations Related to the CitationView, CitationModel, or Citations collection labels May 1, 2024
@rushirajnenuji rushirajnenuji added this to the 2.29.0 milestone May 1, 2024
@rushirajnenuji rushirajnenuji self-assigned this May 1, 2024
rushirajnenuji added a commit that referenced this issue May 1, 2024
@rushirajnenuji
Only use inline import, remove the top level model import to avoid ci…
28f6859 
…rcular dependency

Only use inline import, remove the top level model import to avoid circular dependency

Reference: #2395
rushirajnenuji added a commit that referenced this issue May 2, 2024
@rushirajnenuji
Restore dual require for Citations collection; add dual require for C…
e2e9b7c 
…itation Model

Restore dual require for Citations collection; add dual require for Citation Model

#2395
@robyngit robyngit modified the milestones: 2.29.0, 2.30.0 May 6, 2024
@mbjones
Copy link
Member

mbjones commented Jun 12, 2024

@rushirajnenuji @robyngit I'm still seeing this problem on FF 126.0.1 on MacOS, for ADC and ESS-DIVE at least.

image

@robyngit robyngit modified the milestones: 2.30.0, 2.31.0 Jun 20, 2024
@rushirajnenuji
Copy link
Member Author

rushirajnenuji commented Aug 26, 2024 •
edited
Loading

Update:

  • Jim ran into this error when looking at ESS DIVE Citations.
    image

Jim saw these issues on the following browser versions:

Chrome 127.0.6533.100 on my MBP
Safari 17.5 on my MBP
Current Safari on my iPhone (iOS 17.5.1)
  • @jeanetteclark was able to see the citations displayed with the older FF version
    Screen Shot 2024-08-26 at 11 58 43 AM
Firefox 128.0.3

I verified that the fix above resolves the issue for my local development instance (on both latest Chrome and FF).

Next steps:
Test some more and PR. Hoping to get this in for the 2.31.0 release

@rushirajnenuji rushirajnenuji mentioned this issue Sep 5, 2024
Merged
@robyngit robyngit linked a pull request Sep 5, 2024 that will close this issue
Bugfix 2395 citations display #2510
Merged
@robyngit robyngit closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushirajnenuji rushirajnenuji

Labels
bug citations Related to the CitationView, CitationModel, or Citations collection
Projects
None yet
Milestone
2.31.0
Development

Successfully merging a pull request may close this issue.

Bugfix 2395 citations display NCEAS/metacatui
3 participants
@mbjones @rushirajnenuji @robyngit