Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the DataONE accounts/pendingmap request fails for an ORCID, try to find the account with other ORCID formatting #651

Closed
laurenwalker opened this issue Jun 13, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@laurenwalker
Copy link
Member

We recently had someone try to link their older account to their ORCID account by inputting their ORCID in the text input as '0000-0000-0000-0000". The request failed because the account username has the ORCID formatted as http://orcid.org/0000-0000-0000-000. An error message was displayed to the user.

What we should really do is try to find the ORCID account with various ORCID formats before displaying an error message to the user.

Also, the error message received from LDAP could be translated to be more understandable. The error message of [LDAP: error code 32 - No Such Object] is really difficult to understand. It should instead say something like, The username {username} does not exist in our system. Please check that your username is spelled correctly and that you have logged into your account at least once on the {repo name}.

@laurenwalker laurenwalker added this to the 2.1.0 milestone Jun 13, 2018
@laurenwalker laurenwalker self-assigned this Jun 13, 2018
@mbjones
Copy link
Member

mbjones commented Jun 14, 2018

In our discussions with @csjx on modifying the account support for ORCIDs, we discussed making all forms of ORCIDs equivalentIdentities automatically without a specific user request to do so, so that when logins switch from http to https, the old http identities in access rules will still be valid.

@laurenwalker laurenwalker modified the milestones: 2.1.0, 1.14.16 Jun 14, 2018
laurenwalker added a commit that referenced this issue Jun 14, 2018
…CID, reformat it for them before giving up.

Also improved the error message when a username is not found in LDAP.

Closes #651
@laurenwalker
Copy link
Member Author

Until that work is complete, I went ahead and added a stopgap where we reformat ORCIDs on the user's behalf when they have used an incorrect format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants