Fit cesium map toolbar size to content #2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At 100% height the toolbar blocked the map below even though it had no interactable elements below. GitHub issue: NCEAS#2207
Set a fixed height for body element to force map view to appear on page. Add some padding to allow for scrollbar in layers toolbar. Fix issue with cutting off last layer in toolbar on narrow laptop screen due to a hardcoded value for the header height. GitHub issue: NCEAS#2242 temp commit with changes for PR comments
|
Hey @ianguerin, thanks for picking up another issue! Wondering why you closed this PR? I think this is the preferable solution over #2256 |
|
I didn't intend to open this PR, that was my mistake while wondering "what does this button do" on GitHub. |
|
ah, understood, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 100% height the toolbar blocked the map below even though it had no interactable elements below.
GitHub issue: #2207