Allow navigating directly to a page in the Cesium-based data catalog #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triggerSearch in Filters-Search connector was resetting the page to 1 Fixes #2328
iannesbitt
requested changes
Mar 27, 2024
|
Revising my review to an approve because the issue I saw is only applicable to themes that still use the google maps api ( |
iannesbitt
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggerSearch in Filters-Search connector was resetting the page to 1 because it was passing on arguments from the listener that called it. The argument was triggering the 'resetPage' option in the triggerSearch method.