Legend 3: Add legend to map #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnesjy
force-pushed
the
feature-1784-add-legend-to-map
branch
from
1550291
to
84fe9f8
Compare
ianguerin
approved these changes
Jun 11, 2024
robyngit
requested changes
Jun 17, 2024
There was a problem hiding this comment.
This legend is going to be great! 🎉🎉🎉
A couple minor aesthetic issues I noticed:
On maps without the light theme, e.g. in the catalog, the panels element is weirdly translucent or has a darker text color:
Could we bump the positioning of the legend up on portal maps on smaller screens? See:
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
These scoped type names are used inconsistently throughout the code base and violate lint rules. I will not attempt a fix in this PR, and hold off until we have an agreed upon approach.
yvonnesjy
force-pushed
the
feature-1784-add-legend-to-map
branch
from
84fe9f8
to
a990776
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.