-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#97, #98) Update app module architecture with NCIDS components #99
base: develop
Are you sure you want to change the base?
Conversation
Viewing Information |
4d2277a
to
23af355
Compare
23af355
to
18b1563
Compare
5b648e3
to
9e35e6d
Compare
30732b1
to
2babd26
Compare
2babd26
to
73d1035
Compare
1641a92
to
72a2320
Compare
72a2320
to
51b17a2
Compare
51b17a2
to
892d0cd
Compare
892d0cd
to
51b17a2
Compare
51b17a2
to
7916943
Compare
e44356a
to
39eacaf
Compare
7f3fadf
to
6d31c74
Compare
6d31c74
to
047255f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good on react-app-dev
!
adb9fb9
to
6edbfdd
Compare
6edbfdd
to
124714e
Compare
package.json
Outdated
"sass": "^1.54.9", | ||
"sass-loader": "^10.3.1", | ||
"sass": "^1.63.6", | ||
"sass-loader": "^10.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bryan pointed out that this package is downgrading?
src/hooks/customFetch.js
Outdated
@@ -1,7 +1,7 @@ | |||
import { useEffect, useState } from 'react'; | |||
import { useQuery } from 'react-fetching-library'; | |||
|
|||
export const useCustomQuery = (action, shouldFetch = true) => { | |||
export let useCustomQuery = (action, shouldFetch = true) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the switch to let
here?
@include u-font-family('body'); | ||
margin-left: 10px; | ||
padding-top: 4px; | ||
padding-bottom: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file needs to be formatted
124714e
to
621ad5e
Compare
* Update header and footer within index.html * Update webpack config sass-loader * Add ncids-application-page.scss * Add reference to cancer.gov ncids-minimal.css stylesheet within index.html * Connect toggle / dropdown select to translation * Add `ncids-application-page.scss` and updated `webpack.config` file to configure sass-loader with added load paths * Update `css-loader` from `3.4.2` to `5.2.7`, `postcss-loader` from `3.0.0` to `4.3.0` * Downgrade `sass-loader` from `10.4.1` t0 `10.2.0` * Update `webpack.config` * Remove reference to cancer.gov ncids-minimal.css stylesheet within index.html * Create entrypoint in `webpack.config` that adds `ncids-minimal.css` and `ncids-application-page.css` to app * Update current template to use ncids grid * Add mobile menu * Add tests for SideNav and ItemDetail view * Add `svg-loader` config to webpack * Fix typo and pathing in `getSampleCallResults` which was causing api call failure * Update `PageNotFound` error page * Remove all previous postcss related packages and replaced with `postcss`, postcss-loader` and `autoprefixer` * Add fonts to `index.html` * Revert changes in `PageNotFound`. To be reconstructed in line with NCIDS layout/styling * Add back `postcss-safe-parser` and `postcss-prefix-selector` * Remove `generate-cgdp-legacy.js` file along with references in `package.json` to run build script, and `postcss-prefix-selector` which was used in the file. * Remove `HomeNoSideNav` component and all references * Update `PageNotFound` component to conform with NCIDS styling * Update unit tests for `PageNotFound` * Fix missing base path for page not found link * Add basepath to `apiEndpoint` used to initiate app in `index.js` for `react-app-dev.cancer.gov` * Added `ncids-react` alpha package for POC Closes #97 * Update supported browsers browserslist property in package.json Closes #98
621ad5e
to
c90663f
Compare
(#97, #98) Update app module architecture with NCIDS components
ncids-application-page.scss
and updatedwebpack.config
file to configure sass-loader with added load pathscss-loader
from3.4.2
to5.2.7
,postcss-loader
from3.0.0
to4.3.0
sass-loader
from10.4.1
t010.2.0
webpack.config
webpack.config
that addsncids-minimal.css
andncids-application-page.css
to appsvg-loader
config to webpackgetSampleCallResults
which was causing api call failurePageNotFound
error pagepostcss
, postcss-loaderand
autoprefixer`index.html
PageNotFound
. To be reconstructed in line with NCIDS layout/stylingpostcss-safe-parser
andpostcss-prefix-selector
generate-cgdp-legacy.js
file along with references inpackage.json
to run build script, andpostcss-prefix-selector
which was used in the file.HomeNoSideNav
component and all referencesPageNotFound
component to conform with NCIDS stylingPageNotFound
apiEndpoint
used to initiate app inindex.js
forreact-app-dev.cancer.gov
Closes #97
Closes #98