Added --nest-top-dir flag to allow nestpy to be set to use user's NEST source code instead of that in src/nestpy/ #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T source code instead of that in src/nestpy/ usage: python setpy.py install --nest-top-dir="/path/to/NEST/" Nest top dir should include src/ and include/ directories, as with the NEST git repo
|
Right now, nest is building against it's own copy of the code that puts it in one folder. The whole C++ nest is shipped to aid installation. However, if you're modifying your own NEST, I agree this is useful! Will merge for next release. Next release would be with the next NEST release, but can make an intermediate nestpy release if necessary. |
tunnell
approved these changes
Jun 22, 2020
|
@jpbrodsky can you update your branch with the main branch to see if the tests pass with custom version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage: python setpy.py install --nest-top-dir="/path/to/NEST/"
(pip install nestpy --install-option="/path/to/NEST/" might work?)
Nest top dir should include src/ and include/ directories, as with the NEST git repo