-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xin's version with added functions #30
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s slow though. We will have to find a way to move field dependence vTable outside
Thanks for these nice proposals. We don't modify the CPP itself in nestpy, but sync to NEST. See NESTCollaboration/nest#54 for next steps. |
Stale PR. @xxiang4, if you are still able to, we'd be happy to have your developed code in our bindings to nestpy - please go ahead and open a new PR with those python-specific changes if you would like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default to LUX detector.
Add two functions ---
RunNEST(...)
and RunNEST_vec(...)`. The first function takes in an energy and a position, and output s1, s2, while the second one takes in a list of energies and positions, and output a list of s1, s2.The NEST built-in spectrum (ex. WIMP_dRate) are binded. User can now access them via nestpy.