fix(module:tooltip): fix tooltip accessing destroyed view

close #3875 close #4317 close #4386
NG-ZORRO · Nov 8, 2019 · 455d90c · 455d90c
1 parent 2a71c43
commit 455d90c
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/components/tooltip/base/nz-tooltip-base.directive.ts b/components/tooltip/base/nz-tooltip-base.directive.ts
@@ -199,6 +199,10 @@ export abstract class NzTooltipBaseDirective implements OnChanges, OnInit, OnDes
   ngOnDestroy(): void {
     this.$destroy.next();
     this.$destroy.complete();
+
+    // Clear toggling timer. Issue #3875 #4317 #4386
+    this.hide();
+    this.clearTogglingTimer();
     this.removeTriggerListeners();
 
     if (this.tooltipRef) {
@@ -338,10 +342,9 @@ export abstract class NzTooltipBaseDirective implements OnChanges, OnInit, OnDes
   }
 
   private delayEnterLeave(isOrigin: boolean, isEnter: boolean, delay: number = -1): void {
-    if (this.delayTimer) {
-      clearTimeout(this.delayTimer);
-      this.delayTimer = undefined;
-    } else if (delay > 0) {
+    this.clearTogglingTimer();
+
+    if (delay > 0) {
       this.delayTimer = setTimeout(() => {
         this.delayTimer = undefined;
         isEnter ? this.show() : this.hide();
@@ -357,4 +360,11 @@ export abstract class NzTooltipBaseDirective implements OnChanges, OnInit, OnDes
     this.triggerUnlisteners.forEach(cancel => cancel());
     this.triggerUnlisteners.length = 0;
   }
+
+  private clearTogglingTimer(): void {
+    if (this.delayTimer) {
+      clearTimeout(this.delayTimer);
+      this.delayTimer = undefined;
+    }
+  }
 }