Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[carousel] Auto switch from the last slide to the first one seems strange #2218

Closed
wanpeng2008 opened this issue Sep 29, 2018 · 6 comments · Fixed by #3062
Closed

[carousel] Auto switch from the last slide to the first one seems strange #2218

wanpeng2008 opened this issue Sep 29, 2018 · 6 comments · Fixed by #3062
Assignees
@wzhudev
Labels
Component: Carousel 💪 Enhancement 💰 IssueHuntFest

Comments

@wanpeng2008
Copy link

Version

1.6.0

Environment

web

Reproduction link

https://ng-zorro-antd-start-pv7vcd.stackblitz.io

Steps to reproduce

Make a carousel with auto-play following the guide

What is expected?

The switch from the last slide to first one should be smooth and clear.

What is actually happening?

It looks like all slides go backwards quickly before switching to the first slide.

Other?

Root cause : in carousel switch implementation, it should use animation instead of css transform. I think i can help on this issue.
@wzhudev
Copy link
Member

wzhudev commented Sep 29, 2018 •
edited
Loading

Duplicates #2014. But I am afraid we are now short of hands fixing this animation. Thanks for your report.

Actually since the React version of Ant Design implemented this animation, it wouldn't be hard to do. Are you interested in that? @wanpeng2008

Conversations could be continued there.

@wzhudev wzhudev closed this as completed Sep 29, 2018
@wanpeng2008
Copy link
Author

wanpeng2008 commented Sep 30, 2018 via email

@wzhudev
Copy link
Member

wzhudev commented Sep 30, 2018 •
edited
Loading

@wanpeng2008 Ok then. I will assign this issue to you.

@wzhudev wzhudev reopened this Sep 30, 2018
@wzhudev wzhudev removed their assignment Sep 30, 2018
@wzhudev
Copy link
Member

wzhudev commented Oct 8, 2018

@wanpeng2008 开源社区的工作都应该在公开的地方进行, 比如 GtiHub 的 issue.

你向哪里推送的代码?

应该推送你的修改到你 fork 的项目, 然后发起 pull request.

wanpeng2008 added a commit to wanpeng2008/ng-zorro-antd that referenced this issue Oct 8, 2018
@wanpeng2008
fix(module:carousel): slide switching issue NG-ZORRO#2218
9ae9c07 
to fix issues: NG-ZORRO#2218, also NG-ZORRO#2014
the switch action is implemented by animation instead of transform,
test case carousel ‘should effect change work’ is temporarily pending
@wanpeng2008 wanpeng2008 mentioned this issue Oct 8, 2018
Closed
3 tasks
wanpeng2008 added a commit to wanpeng2008/ng-zorro-antd that referenced this issue Oct 8, 2018
@wanpeng2008
fix(module:carousel): slide switching issue NG-ZORRO#2218
3a814c7 
to fix issues: NG-ZORRO#2218, also NG-ZORRO#2014
the switch action is implemented by animation instead of transform;
swipeInProgress changes to animation implementtaion.
Update test case 'should effect change work'.
Add Test case 'should slide switch follow the shortest path'.
Pending test case 'should swipeInProgress work',
cause haven't found a good way to test animations.
wanpeng2008 added a commit to wanpeng2008/ng-zorro-antd that referenced this issue Oct 8, 2018
@wanpeng2008
fix(module:carousel): slide switching issue NG-ZORRO#2218
b5366fd 
to fix issues: NG-ZORRO#2218, also NG-ZORRO#2014
the switch action is implemented by animation instead of transform;
swipeInProgress changes to animation implementtaion.
Update test case 'should effect change work'.
Add Test case 'should slide switch follow the shortest path'.
Pending test case 'should swipeInProgress work',
cause haven't found a good way to test animations.
wanpeng2008 added a commit to wanpeng2008/ng-zorro-antd that referenced this issue Oct 8, 2018
@wanpeng2008
fix(module:carousel): slide switching issue NG-ZORRO#2218
8c1e50b 
to fix issues: NG-ZORRO#2218, also NG-ZORRO#2014
the switch action is implemented by animation instead of transform;
swipeInProgress changes to animation implementtaion.
Update test case 'should effect change work'.
Add Test case 'should slide switch follow the shortest path'.
Pending test case 'should swipeInProgress work',
cause haven't found a good way to test animations.
@IssueHuntBot
Copy link

@0maxxam0 funded this issue with $20. See it on IssueHunt

@wzhudev wzhudev mentioned this issue Jan 15, 2019
Closed
@wzhudev wzhudev mentioned this issue Mar 22, 2019
Merged
5 tasks
@wzhudev wzhudev assigned wzhudev and unassigned wanpeng2008 Mar 29, 2019
vthinkxie pushed a commit that referenced this issue Apr 18, 2019
@vthinkxie
refactor(module:carousel): refactor (#3062)
cc1910a 
* refactor(module:carousel): refactor

* fix: move some listeners to body

* fix: fix vertical context preparing dragging from first to last

* fix: opacity strategy transition

* fix(module:breadcrumb): add input boolean

* feat: support SSR

* fix: lint

* fix: fix active index not reset when content changes
close #2468, close #2218
@IssueHuntBot
Copy link

@vthinkxie has rewarded $18.00 to @wendzhue. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $2.00

andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@andrew-yangy
refactor(module:carousel): refactor (NG-ZORRO#3062)
ca7c0f0 
* refactor(module:carousel): refactor

* fix: move some listeners to body

* fix: fix vertical context preparing dragging from first to last

* fix: opacity strategy transition

* fix(module:breadcrumb): add input boolean

* feat: support SSR

* fix: lint

* fix: fix active index not reset when content changes
close NG-ZORRO#2468, close NG-ZORRO#2218
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
refactor(module:carousel): refactor (NG-ZORRO#3062)
5571186 
* refactor(module:carousel): refactor

* fix: move some listeners to body

* fix: fix vertical context preparing dragging from first to last

* fix: opacity strategy transition

* fix(module:breadcrumb): add input boolean

* feat: support SSR

* fix: lint

* fix: fix active index not reset when content changes
close NG-ZORRO#2468, close NG-ZORRO#2218
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
refactor(module:carousel): refactor (NG-ZORRO#3062)
b839010 
* refactor(module:carousel): refactor

* fix: move some listeners to body

* fix: fix vertical context preparing dragging from first to last

* fix: opacity strategy transition

* fix(module:breadcrumb): add input boolean

* feat: support SSR

* fix: lint

* fix: fix active index not reset when content changes
close NG-ZORRO#2468, close NG-ZORRO#2218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
Component: Carousel 💪 Enhancement 💰 IssueHuntFest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(module:carousel): refactor wzhudev/ng-zorro-antd
3 participants
@wanpeng2008 @wzhudev @IssueHuntBot