Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <nz-root> component optional #34

Closed
4 tasks done
trotyl opened this issue Aug 16, 2017 · 2 comments
Closed
4 tasks done

Make <nz-root> component optional #34

trotyl opened this issue Aug 16, 2017 · 2 comments
Assignees

Comments

@trotyl
Copy link
Contributor

trotyl commented Aug 16, 2017

I'm submitting a...


[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

As suggested in doc, <nz-root> component must be listed at outermost layer of the app, which seems inconvenient for user.

Expected behavior

High-level goal:

Do not require <nz-root> in component template.

Detailed design:

  • Add optional configuration param in forRoot() method.
  • Introduce a separate InjectionToken for that configuration param.
  • Use a dynamic component to apply global styles.
  • Use a APP_INITIALIZER to apply font styles.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z

ng-zorro-antd version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@nikhilbangre
Copy link

when nzDrawerService Release.

@lock
Copy link

lock bot commented Sep 12, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants